Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate readiness reporter listen port and use unix domain socket #12001

Open
jijiechen opened this issue Nov 11, 2024 · 4 comments
Open

Deprecate readiness reporter listen port and use unix domain socket #12001

jijiechen opened this issue Nov 11, 2024 · 4 comments
Labels
blocked This is blocked by another issue or something external kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@jijiechen
Copy link
Member

Description

The readiness reporter listens to port 9902 by default and it create port conflict issues when runs multiple instances on the same host. Users need to specify different ports per instance manually using environment variables.
Kuma CP/DP does not support Windows systems, so it's safe to use unix domain sockets to replace the port number.
@jijiechen jijiechen added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Nov 11, 2024
@lukidzi
Copy link
Contributor

lukidzi commented Nov 12, 2024 •
edited
Loading

triage: Yes, we can get it now

@lukidzi lukidzi added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Nov 12, 2024
@lahabana
Copy link
Contributor

Let's first check if Windows build is indeed disabled. As this will not work on Windows

@jijiechen
Copy link
Member Author

Confirmed by @johnharris85 , we need to maintain Windows compatibility until April (likely 2.11)

@lahabana
Copy link
Contributor

Delay this until Windows support is fully removed

@lahabana lahabana added the blocked This is blocked by another issue or something external label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked This is blocked by another issue or something external kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lahabana @jijiechen @lukidzi