fix(gateway): change MeshGateway tags validation to be consistent with MeshRoute tags validation #11808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ags validation Signed-off-by: Marcin Skalski <[email protected]>
Automaat
requested review from
slonka and
lobkovilya
and removed request for
a team
Automaat
changed the title
slonka
approved these changes
Oct 21, 2024
Signed-off-by: Marcin Skalski <[email protected]>
|
I thought the MeshGateway was already looser, what's the difference between routes and gateways? |
|
Why can't we just have
|
michaelbeaumont
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11806
Motivation
Right now, MeshGateway tags validation is more loose than validation of tags in Mesh*Route which lets you create Gateway you won't be able to reference in Mesh*Route.