Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink building SNI for multizone MeshService #10469

Open
jakubdyszkiewicz opened this issue Jun 14, 2024 · 6 comments
Open

Rethink building SNI for multizone MeshService #10469

jakubdyszkiewicz opened this issue Jun 14, 2024 · 6 comments
Assignees
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it
Milestone

Comments

@jakubdyszkiewicz
Copy link
Contributor

Description

The current way is a bit hacky
#10451 (comment)
While it works, we should consider something more robust.

Options that come to my mind:

  1. More labels
  2. Put SNI in MeshService and sync it cross zone. This is nice but how to handle splits?

xref #10435

@jakubdyszkiewicz jakubdyszkiewicz added triage/pending This issue will be looked at on the next triage meeting kind/improvement Improvement on an existing feature labels Jun 14, 2024
@lobkovilya lobkovilya added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Jun 17, 2024
@lahabana lahabana added this to the 2.9.x milestone Jul 2, 2024
@jakubdyszkiewicz
Copy link
Contributor Author

xref #10918

@jakubdyszkiewicz jakubdyszkiewicz self-assigned this Jul 17, 2024
@lahabana
Copy link
Contributor

lahabana commented Aug 1, 2024

@jakubdyszkiewicz does this cover the implem of MADR-59?

@michaelbeaumont michaelbeaumont modified the milestones: 2.9.x, 2.10.x Sep 9, 2024
@jakubdyszkiewicz
Copy link
Contributor Author

@lahabana
Copy link
Contributor

lahabana commented Dec 5, 2024

Put SNI in MeshService and sync it cross zone. This is nice but how to handle splits?

Do we agree that we decided to not do splits?

@lahabana
Copy link
Contributor

lahabana commented Dec 5, 2024

Also we agree that the format is agreed on and this change would be just to remove the zone CP to "make up" the format for remote access to services?

In other words this is an improvement but there wouldn't be a breaking change in implementing this (just if the SNI is in the MeshService object use this instead)

@jakubdyszkiewicz
Copy link
Contributor Author

Do we agree that we decided to not do splits?

Yes, we do not do splits anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

No branches or pull requests

4 participants