Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error upgrading to latest version #12762

Closed
adalfa opened this issue Jan 28, 2025 · 7 comments
Closed

error upgrading to latest version #12762

adalfa opened this issue Jan 28, 2025 · 7 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@adalfa
Copy link

adalfa commented Jan 28, 2025

Hello,

What happened:
performing an upgrade to the latest version we get
helm upgrade --reuse-values --set controller.ingressClassResource.name="ingress-default" ingress -nginx ingress-nginx/ingress-nginx Error: UPGRADE FAILED: template: ingress-nginx/templates/admission-webhooks/job-patch/job-patchWebhook.yaml:45:82: executing "ingress-nginx/templates/admission-webhooks/ job-patch/job-patchWebhook.yaml" at <.Values.global.image>: nil pointer evaluating interface {}.image

What you expected to happen:

the upgrade shold run smoothly

Environment:

  • AKS 1.29.8

  • Current State of the controller:

we've tried a 4.11.2 direct upgrade to 4.12.0 and we got the error
we was able to upgrade to 4.11.2->4.11.4 without issue

@adalfa adalfa added the kind/bug Categorizes issue or PR as related to a bug. label Jan 28, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Jan 28, 2025
@Gacko
Copy link
Member

Gacko commented Jan 28, 2025

Which Helm version are you using?

@adalfa
Copy link
Author

adalfa commented Jan 28, 2025

v3.15.4 thanks

@Gacko
Copy link
Member

Gacko commented Jan 28, 2025

Ok, this is a quite recent version. Can you provide the values which are being handed to helm install? Feel free to omit secrets. I think something is setting .global to nil there. Because we're defining this in our values, but it's not defined or set to nil in your values.

Have you tried omitting the reuse-values flag? I can imagine this to be an issue as .global.image is a new key and it might not exist in your present values.

@adalfa
Copy link
Author

adalfa commented Jan 28, 2025

here the comand used for install
helm install ingress-nginx ingress-nginx/ingress-nginx --namespace ingress-nginx --set controller.nodeSelector."kubernetes.io/os"=linux --set controller.admissionWebhooks.patch.nodeSelector."kubernetes.io/os"=linux --set controller.service.annotations."service.beta.kubernetes.io/azure-load-balancer-health-probe-request-path"=/healthz --set controller.service.annotations.'service.beta.kubernetes.io/azure-load-balancer-internal'="true" --set controller.service.annotations.'service.beta.kubernetes.io/azure-load-balancer-internal-subnet'="snet-XXX-aks-ingress-westeu-001" --set controller.service.annotations.'service.beta.kubernetes.io/azure-load-balancer-ipv4'="XXX.XXX.XXX.XXX"

@Gacko
Copy link
Member

Gacko commented Jan 29, 2025

Can you please try without the --reuse-values flag?

@adalfa
Copy link
Author

adalfa commented Jan 30, 2025

it worked thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Development

No branches or pull requests

3 participants