Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User Guide] Rate-Limit annotations lack explanation of confusing behavior #12711

Closed
tback opened this issue Jan 16, 2025 · 2 comments · Fixed by #12714
Closed

[User Guide] Rate-Limit annotations lack explanation of confusing behavior #12711

tback opened this issue Jan 16, 2025 · 2 comments · Fixed by #12714
Labels
needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@tback
Copy link
Contributor

tback commented Jan 16, 2025

User Guide Rate-Limiting Annotations are easily understood as global limits when they're in fact per ingress controller replica. Users in need of exact rate limits cannot use the horizontal autoscaler anymore. Users do not necessarily know the number of deployed replicas of the ingress controller.

The rate limiting section therefore needs at least an in detail explanation of this rather confusing behavior.

@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels Jan 16, 2025
@strongjz
Copy link
Member

@tback, Can you update the documentation? This feature was removed, so I'm not hard-pressed to put it on the Maintainers' TODO list.

#11851

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Development

Successfully merging a pull request may close this issue.

3 participants