From aec133d9e904c4b6be4ff10abbad4ec702c13035 Mon Sep 17 00:00:00 2001 From: Javey Date: Thu, 7 Mar 2024 11:44:05 +0800 Subject: [PATCH] fix(Dropdown): comment will be treat as VNode in vue3, close #975 --- components/dropdown/dropdown.ts | 2 +- packages/kpc-vue-next/__tests__/components/dropdown.spec.ts | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/components/dropdown/dropdown.ts b/components/dropdown/dropdown.ts index 1e190c422..febfb38c8 100644 --- a/components/dropdown/dropdown.ts +++ b/components/dropdown/dropdown.ts @@ -99,7 +99,7 @@ export class Dropdown< // ignore whitespaces between elements in Vue if ((this as any).$isVue || (this as any).$isVueNext) { if (Array.isArray(children)) { - children = children.filter(child => child !== ' '); + children = children.filter(child => child !== ' ' && child /* comment is null in vue3 */); } } if (process.env.NODE_ENV !== 'production') { diff --git a/packages/kpc-vue-next/__tests__/components/dropdown.spec.ts b/packages/kpc-vue-next/__tests__/components/dropdown.spec.ts index 5b22ef3ef..b0f39ee96 100644 --- a/packages/kpc-vue-next/__tests__/components/dropdown.spec.ts +++ b/packages/kpc-vue-next/__tests__/components/dropdown.spec.ts @@ -27,6 +27,7 @@ describe('Dropdown', () => { item 2 item 3 + `,