Negative Numbers are converted to huge numbers

[qrizly2]

• Operating System: Linux
• PHP Version: 8.1.2
• php-mysql-replication Version: v7.0.1
• *mysql version (SELECT VERSION();): 5.7.36-log

Steps required to reproduce the problem.

1. setup a MySQL server with Binary Log Format=ROW format
2. update a row with a negative number (-4444)
3. Listen with a subscriber for an update event

Expected Result.

• Number is a negative number (-4444)

Actual Result.

• Huge positive number (4294962852)

I already have this snippet in place to fix the values, but what should be the preferred way of doing this correctly?

    protected function fixSignedNumbers(RowsDTO $event, array $values): array
    {
        /**  @var \MySQLReplication\Event\RowEvent\ColumnDTO $column */
        foreach ($event->getTableMap()->getColumnDTOCollection() as $column) {
            if(
                isset($values[ $column->getName() ]) &&
                is_int($values[ $column->getName() ]) &&
                ! $column->isUnsigned()
            ) {
                list($type) = explode("(", $column->getFieldDTO()->getColumnType());

                switch ($type) {
                    case 'int':
                        if($values[ $column->getName() ] > 2147483647) {
                            $values[ $column->getName() ] = $values[ $column->getName() ] - 2147483647 - 2147483647 - 2;
                        }
                        break;
                    case 'mediumint':
                        if($values[ $column->getName() ] > 8388607) {
                            $values[ $column->getName() ] = $values[ $column->getName() ] - 8388607 - 8388607 - 2;
                        }
                        break;
                    case 'smallint':
                        if($values[ $column->getName() ] > 32767) {
                            $values[ $column->getName() ] = $values[ $column->getName() ] - 32767 - 32767 - 2;
                        }
                        break;
                    case 'tinyint':
                        if($values[ $column->getName() ] > 127) {
                            $values[ $column->getName() ] = $values[ $column->getName() ] - 127 - 127 - 2;
                        }
                        break;
                }
            }
        }

        return $values;
    }

[qrizly2]

I think i found the issue: but is this enough?

[MySQLReplication\Tests\Unit\BinaryDataReader\BinaryDataReaderTest]

    /**
     * @test
     */
    public function shouldNegativeReadInt32(): void
    {
        $expected = -4444;
        self::assertSame($expected, $this->getBinaryRead(self::pack32bit(-4444))->readInt32());
    }

    public static function pack32bit(int $value): string
    {
        return pack(
            'C4', ($value >> 0) & 0xFF, ($value >> 8) & 0xFF, ($value >> 16) & 0xFF, ($value >> 24) & 0xFF
        );
    }

[MySQLReplication\BinaryDataReader\BinaryDataReader]

    public function readInt32(): int
    {
        $re = unpack('i', $this->read(self::UNSIGNED_INT32_LENGTH))[1];
        return $re >= 0x80000000 ? $re - 0x100000000 : $re;
    }

[qrizly2]

Ok, it seems it is fine for the other int Types

[MySQLReplication\Tests\Unit\BinaryDataReader\BinaryDataReaderTest]

    /**
     * @test
     */
    public function shouldNegativeReadInt64(): void
    {
        $expected = '-4444';
        self::assertSame($expected, $this->getBinaryRead(BinaryDataReader::pack64bit(-4444))->readInt64());
    }

    /**
     * @test
     */
    public function shouldNegativeReadInt8(): void
    {
        $expected = -44;
        self::assertSame($expected, $this->getBinaryRead(self::pack8bit(-44))->readInt8());
    }

    /**
     * @test
     */
    public function shouldNegativeReadInt16(): void
    {
        $expected = -4444;
        self::assertSame($expected, $this->getBinaryRead(self::pack16bit(-4444))->readInt16());
    }

    public static function pack16bit(int $value): string
    {
        return pack(
            'C2', ($value >> 0) & 0xFF, ($value >> 8) & 0xFF
        );
    }

    public static function pack8bit(int $value): string
    {
        return pack(
            'C1', ($value >> 0) & 0xFF
        );
    }