Adding proxy settings to client setting #349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaitanyaenr
approved these changes
Nov 7, 2022
ghost
suggested changes
Nov 10, 2022
|
@janosdebugs @sandrobonazzola PTAL when you get time please. Thanks. |
|
@paigerube14 let's rebase the PR. |
ghost
approved these changes
Nov 30, 2022
|
Fixes #334. |
|
/funtest |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
closing as this functionality has moved to krkn-lib, will want to move the functionality over there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the same kubernetes config I added to cerberus in PR here, waiting for a private cluster to double check this. Will update if this doesn't work