Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to view database tables anymore #41

Open
wtfzambo opened this issue Dec 6, 2023 · 3 comments · May be fixed by #44
Open

Unable to view database tables anymore #41

wtfzambo opened this issue Dec 6, 2023 · 3 comments · May be fixed by #44

Comments

@wtfzambo
Copy link

wtfzambo commented Dec 6, 2023

Hello, first of all thanks for the driver, really useful!

Secondly, I encountered a little problem recently: If, in the SQLTools panel view, I try to view the tables of any database (see screenshot)

image

I get the following error:

Request connection/GetChildrenForTreeItemRequest failed with message: Cannot read properties of undefined (reading 'ResultSet')

This wasn't happening a couple of weeks ago, so I presume this might be connected to a recent release?

Querying works fine, so I'm not exactly sure what's going on here.

Lemme know what else I can do to help debugging this :) !

@sov-kschroer
Copy link

sov-kschroer commented Jan 11, 2024

Hi everyone,
yes I agree the driver is really helpful.
And I stumbled across the same issue and resort to workarounds by querying the table DDLs manually.

I now played around with different older versions. It looks like SQLTools AWS Athena Driver
v0.3.0 is still working without issues but the latest updates to v.0.3.4 introduced this problem.

@JohniMichels
Copy link
Contributor

We'll fix that issue in the next version. We can only work from time to time on this driver, and vscode had a major upgrade in how to debug the driver, so we had some drawbacks on the latest upgrade.

Aleksei-Poliakov added a commit to Aleksei-Poliakov/sqltools-athena-driver that referenced this issue Apr 4, 2024
Currently trying to expand tables in the connections browser results in an error:
```
Request connection/GetChildrenForTreeItemRequest failed with message: Cannot read properties of undefined (reading 'ResultSet')
```

This happens because `SHOW TABLES` and `SHOW VIEWS` do not return data as regular queries.
Instead it has to be pulled as a separate request.

This fixes kovihq#41
@Aleksei-Poliakov Aleksei-Poliakov linked a pull request Apr 4, 2024 that will close this issue
@jpasner
Copy link

jpasner commented Oct 16, 2024

Hey Folks, just wanted to say I just installed the plugin yesterday and am seeing this exact same issue. Seems a pull request has been created to try and address the issue in April but hasn't been accepted. That said the v0.3.0 workaround suggested above is still valid and works for me 😄

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants