Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stat Binary/Extend after downloading from Src or simply returning local Src #41

Open
korenyoni opened this issue Aug 6, 2018 · 0 comments

Comments

@korenyoni
Copy link
Owner

korenyoni commented Aug 6, 2018

On local Extrend retrievals, os.Stat is performed on the Src which is returned (https://github.com/yonkornilov/snowcapper/blob/master/runner/runner.go#L132-L138). This is not done on remote retrievals.

For Binary retrievals, the os.Stat operation is done in neither remote or local retrievals, and should be done for both.

Renaming downloadPath in getBinary and getExtract to something in favour of local retrievals should be done too.

@korenyoni korenyoni changed the title Stat Binary/Extract after downloading from Src or simply returning local Src Stat Binary/Extend after downloading from Src or simply returning local Src Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant