Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this.cfg vs this.config #822

Open
netniV opened this issue Sep 20, 2021 · 1 comment
Open

this.cfg vs this.config #822

netniV opened this issue Sep 20, 2021 · 1 comment
Labels

Comments

@netniV
Copy link

netniV commented Sep 20, 2021

Describe the bug
Looking at the code, without doing an indepth review and breakdown test, there seems to be mixed using between this.cfg and this.config, the coding style should be consistent to prevent issues. For example, I'm pretty sure this is why the style_path and stylesheet overrides I tried to use failed to work and my browser was constantly trying to use the default path for the stylesheet.

@netniV netniV added the bug label Sep 20, 2021
@koalyptus
Copy link
Owner

Hi @netniV,

Don't hesitate to submit a PR following the guidelines. I agree the usage of this.config in the tablefilter.js seems incorrect, the intention was probably to use this.config().

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants