Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CairoVM requirements #411

Open
enitrat opened this issue Jan 13, 2025 · 0 comments
Open

CairoVM requirements #411

enitrat opened this issue Jan 13, 2025 · 0 comments
Milestone

Comments

@enitrat
Copy link
Collaborator

enitrat commented Jan 13, 2025

Tracking our modification requirements from the CairoVM:

  1. DictTrackers dictionaries:
    a. They only accept MaybeRelocatable as keys. As our keys don't necessarily fit in felts (hashdicts), we want to accept compound types as dictionary keys. action taken: a enum DictKey {Simple(MaybeRelocatable, Compound(Vec<MaybeRelocatable>)} as key type.
    b. dict.get, when used on a default dict, inserts that key in the dict. We don't want this happening: getting a default value should not create an entry in the tracker, but should simply log this in cairo.
@github-project-automation github-project-automation bot moved this to Backlog in Keth Jan 13, 2025
@ClementWalter ClementWalter added this to the Optimization milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

2 participants