Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overly Concrete Parameter does not handle try blocks well #20

Open
kjlubick opened this issue Aug 1, 2014 · 0 comments
Open

Overly Concrete Parameter does not handle try blocks well #20

kjlubick opened this issue Aug 1, 2014 · 0 comments

Comments

@kjlubick
Copy link
Owner

kjlubick commented Aug 1, 2014

(minor comment, the location is off, but that may be hard to fix)
image

The bug on line 78 is the OCP (The one on 81 is tied to the use of getBytes)

image

By moving the identical code into a try block, both bugs go away, but only the one involving the getBytes() should have vanished
kjlubick added a commit that referenced this issue Aug 3, 2014
@kjlubick
Replicated test case for OCP false negative
dddda3b 
See /issues/20 for more details.
Some investigation shows that simply printing the stack trace in the catch
clause will not invoke the false negative
@kjlubick kjlubick mentioned this issue Aug 3, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kjlubick