Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider computing checksum of uploaded parts #146

Open
brianhelba opened this issue Dec 7, 2020 · 0 comments
Open

Consider computing checksum of uploaded parts #146

brianhelba opened this issue Dec 7, 2020 · 0 comments

Comments

@brianhelba
Copy link
Contributor

The UploadPart API allows an optional Content-MD5 header to be sent, containing:

The base64-encoded 128-bit MD5 digest of the part data.

For greater guarantees of data integrity, this digest could be computed locally by clients and included with uploads.

This could have a negative performance impact. However, it's possible that for small uploads, the actual extra time is negligible. For large uploads, it may be the case that the bottleneck is in upload bandwidth, so clever pipelining and parallelization will add only an initial constant (and thus amortizable) performance delay and will not actually scale with the upload size.

For the JS client, the most trusted choice of MD5 library seems to be crypto-js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant