-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release of django-allauth 0.58 breaks templates #79
Comments
We should consider this library to be soft-broken by However, I'm not sure whether it makes sense to pin the requirements accordingly, since this will force downstreams to adopt an older version of an important library, just to prevent some style bugs. |
One breaking change is that the link to the This causes the link to now display twice, with The easiest fix is to remove corresponding HTML from |
Fixed by #85. |
Note, https://github.com/danihodovic/django-allauth-ui is broken in the same fundamental ways, but they currently cover a larger set of explicit templates. |
django-allauth
0.58 includes the following change:The changes were made primarily in pennersr/django-allauth#3466 .
At a minimum, the styled pages of
django-auth-style
should be reviewed, to see if anything is broken.Additionally, we should investigate whether it's possible to change this library to apply styles only to the core templates of
django-allauth
, which may reduce the surface area and maintenance burden of this library significantly.The text was updated successfully, but these errors were encountered: