Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Ignore text after "#" in schematic file names #5

Open
gorgonshead opened this issue Apr 26, 2024 · 4 comments
Open
Assignees

Comments

@gorgonshead
Copy link
Collaborator

We've noticed that it's easier to manage percent chances if we use the name group functionality (room_1, room_2). These sets of schematics can get long; can we add the same functionality as loot & spawntables to ignore anything after a "#", to better organize these long sets?

@kitkatod
Copy link
Owner

What would be the purpose of this? I guess I'm not seeing what problem this addresses.

For Loot and Spawn tables, this functionality exists because map keys must be unique, and it can be desirable to define the same item/mob multiple times in a loot/spawn table. The '#______' simply makes the key unique.

@gorgonshead
Copy link
Collaborator Author

gorgonshead commented Apr 26, 2024

If you double the amount of rooms, you throw off all of the weighting for rooms. The solution we currently have is to submap rooms under the same names (for instance, in the egypt dungeon we have like... 11 entries right now under "default_hall", which is working well as we expand the rooms). The problem is I don't remember which one is the one with columns, and which one is the one filled with sand. So I have to pull out rooms until I find the one I want.

@kitkatod
Copy link
Owner

Got it.

Adding this to the file name would be potentially messy, as the file name is already parsed out in a number of different places. Instead it might be possible and more appropriate to add a Description property to sections, and have that description available as a on_hover text when selecting a section to paste.

@kitkatod kitkatod self-assigned this Apr 26, 2024
@gorgonshead
Copy link
Collaborator Author

Yah that sounds like a great solve. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants