Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise extension + Change all of the code #2

Closed
SenpaiHunters opened this issue Mar 23, 2024 · 1 comment
Closed

Optimise extension + Change all of the code #2

SenpaiHunters opened this issue Mar 23, 2024 · 1 comment

Comments

@SenpaiHunters
Copy link
Contributor

SenpaiHunters commented Mar 23, 2024

Whole extension changes:

Refer to my comment on issue #1 .

vscode

  • Changed CSS styles into its own file
  • Changed JS, background.js and popup.js into its own JS location
  • Changed hello.html to popup.html to align with Chromium dev docs
  • Optimise both background.js and popup.js
  • Added support for Ecosia
  • Optimise all images, and removed the second appended image inside the original folder
  • Updated the formatting on all of the code
  • Added a default lang to the html
  • Added a viewpoint to the html
  • Added a title to the html
  • Re-referred everything to its new location
  • Add a .gitignore to the codebase
  • Changed base HTML look via CSS (refer to below img)

Arc - March 03 2024 - 02 43 PM@2x

  • Updated readme.md to remove the need of Node.js, as this is false, it is not needed
    • Changed the readme.md to further outline the install guide, changed the icon to the top of the title
    • Added all search engines to the list, Ecosia included.
    • For a visualisation, refer to the below image

vscode

Before optimisation

Total folder size (minus .git): 120kb
Total extension size (icons included): 32kb
Total extension size (minus icons): 16kb

After optimisation

Total folder size (minus .git): 98kb
Total extension size (icons included): 8kb
Total extension size (minus icons): 5kb

@kishanhitk
Copy link
Owner

kishanhitk commented Mar 24, 2024

Hey @SenpaiHunters thank you so much for the contribution.

The suggested changes looks very useful. Does this also fix incompatibility issue on Windows?

Also, I have added the license, so can you please open a PR with the changes?

SenpaiHunters added a commit to SenpaiHunters/SnapSearch that referenced this issue Mar 24, 2024
kishanhitk added a commit that referenced this issue Apr 14, 2024
Optimise extension + Change all of the code #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants