Dimming sensor #99
Merged
Dimming sensor #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingsleyadam
previously approved these changes
Nov 8, 2024
kingsleyadam
reviewed
Nov 8, 2024
Comment on lines
62
to
64
| if output.get("pairingID") == Pairing.AL_RELATIVE_SET_VALUE_CONTROL.value: | ||
| self._longpress = output.get("value") == "9" or output.get("value") == "8" | ||
| return True |
There was a problem hiding this comment.
Would it be useful to have a long press up and a long press down?
If this is the possible values.
- longpress down: 1
- longpress down release: 0
- longpress up: 9
- longpress up release: 8
You could have a state with an enum with the 4 possible options. In Home Assistant they'd appear as one of the 4 options. That way a user can create automations based on one of the 4 options.
kingsleyadam
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add device support for DimmingSensor
closes #92