Refactor enums, freeathome, pairing #36
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the ENUM's to remove the
id
naming convention.FunctionID
-->Function
ParingID
-->Pairing
ID becomes a bit confusing as it's not an ID, it's an ENUM and the value is an ID.
I've also changed the FreeAtHome object to expose
self._api
as a public attributeself.api
in case we would need to use the api externally (e.g. Home Assistant using the FreeAtHome class to fetch a value from the API). I don't have a use case yet but it's possible.