Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor enums, freeathome, pairing #36

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

kingsleyadam
Copy link
Owner

This PR refactors the ENUM's to remove the id naming convention.

  • FunctionID --> Function
  • ParingID --> Pairing

ID becomes a bit confusing as it's not an ID, it's an ENUM and the value is an ID.

I've also changed the FreeAtHome object to expose self._api as a public attribute self.api in case we would need to use the api externally (e.g. Home Assistant using the FreeAtHome class to fetch a value from the API). I don't have a use case yet but it's possible.

@kingsleyadam kingsleyadam added the enhancement New feature or request label Oct 14, 2024
Copy link

Code Coverage

Package Line Rate Complexity Health
.opt.hostedtoolcache.Python.3.12.7.x64.lib.python3.12.site-packages.abbfreeathome 100% 0
.opt.hostedtoolcache.Python.3.12.7.x64.lib.python3.12.site-packages.abbfreeathome.bin 100% 0
.opt.hostedtoolcache.Python.3.12.7.x64.lib.python3.12.site-packages.abbfreeathome.devices 100% 0
Summary 100% (1065 / 1065) 0

Copy link

TestsPassed ✅Skipped ⏭️Failed ❌
JUnit Test Report61 ran61 passed0 skipped0 failed
TestResult
-No test annotations available-

@kingsleyadam kingsleyadam merged commit e5c488f into main Oct 14, 2024
8 checks passed
@kingsleyadam kingsleyadam deleted the u/kingsleyadam/refactorEnums branch October 14, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant