Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unboundlocalerror #106

Merged
merged 3 commits into from
Nov 10, 2024
Merged

Fix unboundlocalerror #106

merged 3 commits into from
Nov 10, 2024

Conversation

derjoerg
Copy link
Collaborator

@derjoerg derjoerg commented Nov 9, 2024

closes #105

@kingsleyadam kingsleyadam added bug Something isn't working Semver-Patch Bug Fixes & Refactors labels Nov 9, 2024
kingsleyadam
kingsleyadam reviewed Nov 9, 2024
View reviewed changes
Copy link
Owner

@kingsleyadam kingsleyadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think you could adjust the unit tests to test for this scenario as well. If we know we'll get inputs on the websocket, adding a test will ensure we avoid any regressions in the future based on that scenario.

@derjoerg
Copy link
Collaborator Author

derjoerg commented Nov 9, 2024

Do you think you could adjust the unit tests to test for this scenario as well. If we know we'll get inputs on the websocket, adding a test will ensure we avoid any regressions in the future based on that scenario.

I don't know how to add such a unit-test to base.py, so added one in switch_actuator.py

@derjoerg
Copy link
Collaborator Author

derjoerg commented Nov 9, 2024

I don't know how to add such a unit-test to base.py, so added one in switch_actuator.py

I think I have it 😃

@kingsleyadam
Copy link
Owner

I don't know how to add such a unit-test to base.py, so added one in switch_actuator.py

I think I have it 😃

Perfect, thanks!

@kingsleyadam kingsleyadam merged commit cce689b into kingsleyadam:main Nov 10, 2024
2 checks passed
@derjoerg derjoerg deleted the unboundlocalerrer branch November 10, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingsleyadam kingsleyadam kingsleyadam approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Semver-Patch Bug Fixes & Refactors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HA error with version 1.13.0
2 participants
@derjoerg @kingsleyadam