-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support EIA/CEA-708 Closed Captions #103
Comments
Originally brought up on G+ https://plus.google.com/115557954602502982039/posts/TkZ4i7bWBRz by L.Tran |
This should be fixed in builds which use ExoPlayer 2.2.0+ google/ExoPlayer@18a24a1 I don't have any content to test this with (that I know of!), and there are still some issues which have been found and fixed, but aren't in a ExoPlayer release yet: google/ExoPlayer@537a3ab I'm going to close this one out, please reopen anyone has content with EIA/CEA-708 captions and it's not working. |
I just gave the update a try & there are no options for captions. However, if I use Google's network tuner implementation, it shows CC as an option & captions properly work. |
Thanks, will have to see if there's something else needed to make this work :( |
By any chance could you record a few mins of a channel with this kind of caption for me? Details here https://github.com/kiall/android-tvheadend/wiki/Muxdump |
Yeah I will give it a shot sometime this weekend.
Sent from BlueMail
…On Feb 24, 2017, 2:43 AM, at 2:43 AM, Kiall Mac Innes ***@***.***> wrote:
By any chance could you record a few mins of a channel with this kind
of caption for me? Details here
https://github.com/kiall/android-tvheadend/wiki/Muxdump
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#103 (comment)
|
Would you happen to know how to do this in windows?
Sent from BlueMail
…On Feb 24, 2017, 2:43 AM, at 2:43 AM, Kiall Mac Innes ***@***.***> wrote:
By any chance could you record a few mins of a channel with this kind
of caption for me? Details here
https://github.com/kiall/android-tvheadend/wiki/Muxdump
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#103 (comment)
|
Nevermind. I figured it out!
http://www.mediafire.com/file/dqbsvghamqtg143/ATSC_Sample.ts
Sent from BlueMail
…On Feb 24, 2017, 2:43 AM, at 2:43 AM, Kiall Mac Innes ***@***.***> wrote:
By any chance could you record a few mins of a channel with this kind
of caption for me? Details here
https://github.com/kiall/android-tvheadend/wiki/Muxdump
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#103 (comment)
|
@xaudiblex are you sure that contains any subtitles? Neither VLC / ffmpeg show that clip as having any subtitles.. Also - it looks like the "profile=pass" piece of the URL was missed, the linked file is a Matroska / MKV file, which could be the reason the captions are missing. Whatever URL you used, you'll need to add the profile piece to it so it gives the raw mpeg-TS data |
Oh. The docs don't have the profile=pass piece in it, heh. let me update them. |
Ah, Nevermind, it looks like you recorded from a channel, rather than from the service or mux. Recording from a service/mux URL is always in MPEG-TS. I've updated Step 1 of the muxdump wiki to be more clear, could you have another look and try again? Thanks! |
Hopefully this is what we need.
http://www.mediafire.com/file/yhywli7c7zpc2so/ATSC_Sample_Service_Mux.ts
Sent from BlueMail
…On Mar 18, 2017, 4:57 PM, at 4:57 PM, Kiall Mac Innes ***@***.***> wrote:
Ah, Nevermind, it looks like you recorded from a channel, rather than
from the service or mux.
Recording from a service/mux URL is always in MPEG-TS. I've updated
Step 1 of the muxdump wiki to be more clear, could you have another
look and try again? Thanks!
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#103 (comment)
|
Sorry, been travelling so haven't been near the app for a few weeks! As near as I can see, this file still doesn't contain a EIA/CEA caption stream? Also, it's still an MKV file. I'm not sure why you're getting MKV instead of a MPEG-TS stream.
|
Removing Upstream Limitation label, as ExoPlayer does seem to support this now.. I just need sample content to get it going! |
See #203 |
Block on ExoPlayer support:
google/ExoPlayer#1807
The text was updated successfully, but these errors were encountered: