Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate supporting serde(flatten) #3

Closed
ecton opened this issue Feb 10, 2022 · 0 comments · Fixed by #4
Closed

Investigate supporting serde(flatten) #3

ecton opened this issue Feb 10, 2022 · 0 comments · Fixed by #4
Labels
enhancement New feature or request

Comments

@ecton
Copy link
Member

ecton commented Feb 10, 2022 •
edited
Loading

@ModProg reports that using serde(flatten) fails with a SequenceSizeMustBeKnown error. I remembered specifically looking at Bincode when implementing my sequence serialization code. Turns out that Bincode doesn't support serde(flatten) either.

I believe we should be able to add support for this, however, possibly without introducing a new format revision.
@ecton ecton added the enhancement New feature or request label Feb 10, 2022
@ecton ecton moved this to Todo in Beta Roadmap Feb 10, 2022
ecton added a commit that referenced this issue Feb 10, 2022
@ecton
Adding support for serde(flatten)
244b05f 
Closes #3
ecton added a commit that referenced this issue Feb 10, 2022
@ecton
Adding support for serde(flatten)
c9642c6 
Closes #3
@ecton ecton mentioned this issue Feb 10, 2022
Merged
ecton added a commit that referenced this issue Feb 10, 2022
@ecton
Adding support for serde(flatten)
75bd2ca 
Closes #3
ecton added a commit that referenced this issue Feb 10, 2022
@ecton
Adding support for serde(flatten)
a081bdd 
Closes #3
@ecton ecton closed this as completed in #4 Feb 10, 2022
Repository owner moved this from Todo to Done in Beta Roadmap Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Beta Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding support for serde(flatten) khonsulabs/pot
1 participant
@ecton