-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): Error message formatted #797
base: develop
Are you sure you want to change the base?
feat(cli): Error message formatted #797
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
*/ | ||
protected logError( | ||
message: string, | ||
error: { message: string; error: string; statusCode: number } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of passing the message
, you can use error.message.header
User description
Description
Logging errors moved into the
BaseCommand
base class.Fixes #795
Screenshots of relevant screens
Developer's checklist
If changes are made in the code:
Documentation Update
PR Type
Enhancement
Description
Introduced a reusable
logError
method for error handling.Replaced repetitive error logging/reporting with
logError
across commands.Improved code maintainability and consistency in error handling.
Changes walkthrough 📝
20 files
Added reusable `logError` method for error handling
Refactored error handling to use `logError`
Refactored error handling to use `logError`
Refactored error handling to use `logError`
Refactored error handling to use `logError`
Refactored error handling to use `logError`
Refactored error handling to use `logError`
Refactored error handling to use `logError`
Refactored error handling to use `logError`
Refactored error handling to use `logError`
Refactored error handling to use `logError`
Refactored error handling to use `logError`
Refactored error handling to use `logError`
Refactored error handling to use `logError`
Refactored error handling to use `logError`
Refactored error handling to use `logError`
Refactored error handling to use `logError`
Refactored error handling to use `logError`
Refactored error handling to use `logError`
Refactored error handling to use `logError`
28 files