Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLATFORM: Add loading state on deleting a variable #714

Open
poswalsameer opened this issue Feb 8, 2025 · 2 comments
Open

PLATFORM: Add loading state on deleting a variable #714

poswalsameer opened this issue Feb 8, 2025 · 2 comments
Assignees
Labels
difficulty: 2 FOSSHack2025 FOSS Hack is scheduled from Feb 22 to Feb 23. FOSS-accepted issues would have this tag priority: high scope: platform Everything related to the keyshade platform package type: enhancement New feature or request

Comments

@poswalsameer
Copy link
Contributor

Describe the bug
We don't have a loading state on button click while deleting a variable which allows the user to make multiple requests even when one request is ongoing.

Tasks to perform

  • Add loading state.
  • Handle everything gracefully with toast messages ( toast.dismiss(), toast.loading(), toast.success(), toast.error() )
  • Disable the button when the request is going on.

Expected behavior
On clicking once, the user should be able to delete a variable and the request should go single time only.

@poswalsameer poswalsameer added type: enhancement New feature or request scope: platform Everything related to the keyshade platform package priority: high difficulty: 2 FOSSHack2025 FOSS Hack is scheduled from Feb 22 to Feb 23. FOSS-accepted issues would have this tag labels Feb 8, 2025
@chetan102
Copy link

/attempt

Copy link

Assigned the issue to @chetan102!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: 2 FOSSHack2025 FOSS Hack is scheduled from Feb 22 to Feb 23. FOSS-accepted issues would have this tag priority: high scope: platform Everything related to the keyshade platform package type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants