Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Secrets get created even with empty names #701

Closed
2 tasks done
rajdip-b opened this issue Feb 8, 2025 · 18 comments
Closed
2 tasks done

BUG: Secrets get created even with empty names #701

rajdip-b opened this issue Feb 8, 2025 · 18 comments
Assignees
Labels
difficulty: 2 FOSSHack2025 FOSS Hack is scheduled from Feb 22 to Feb 23. FOSS-accepted issues would have this tag good first issue Good for newcomers priority: high scope: api Everything related to the API scope: platform Everything related to the keyshade platform package type: bug Something isn't working

Comments

@rajdip-b
Copy link
Member

rajdip-b commented Feb 8, 2025

Describe the bug

We are able to create secrets with empty names in the platform.

To Reproduce
Steps to reproduce the behavior:

  1. Go to a project in the platform
  2. Click on "Add Secret"
  3. Don't specify a name
  4. Click "Add Secret"
  5. Notice that a secret gets created

Expected behavior

Secrets shouldn't be created with empty names

Screenshots

Image Image Image

Additional Context

@rajdip-b rajdip-b added difficulty: 2 FOSSHack2025 FOSS Hack is scheduled from Feb 22 to Feb 23. FOSS-accepted issues would have this tag good first issue Good for newcomers priority: high scope: api Everything related to the API scope: platform Everything related to the keyshade platform package type: bug Something isn't working labels Feb 8, 2025
@Agastya221
Copy link
Contributor

can you assign me this ?

@rajdip-b
Copy link
Member Author

rajdip-b commented Feb 8, 2025

Hey @Agastya221, @csehatt741 would be working on the backend side of things. If you would like to attempt it, then you can get started with the frontend changes.

@rajdip-b
Copy link
Member Author

rajdip-b commented Feb 8, 2025

@csehatt741 could you please make your attempt?

@csehatt741
Copy link
Contributor

/attempt

Copy link

github-actions bot commented Feb 8, 2025

Assigned the issue to @csehatt741!

@Agastya221
Copy link
Contributor

@rajdip-b yes sure assign me the frontend part

@rajdip-b
Copy link
Member Author

rajdip-b commented Feb 8, 2025

Great!

@rajdip-b
Copy link
Member Author

rajdip-b commented Feb 8, 2025

Just do keep in mind that this issue belongs to FOSS Hack 2025. Do read their guidelines, register yourself and submit the PR during the hackathon window.

@Sohamnimbalkar07
Copy link

/attempt

Copy link

github-actions bot commented Feb 8, 2025

Assigned the issue to @Sohamnimbalkar07!

@rajdip-b
Copy link
Member Author

rajdip-b commented Feb 8, 2025

Hey @Sohamnimbalkar07, I would have to unassign you since there are 2 contributors already attempting this issue. Please refrain from attempting issues that already have assignees.

@Sohamnimbalkar07
Copy link

Sure @rajdip-b. Thanks for letting me know!

@csehatt741
Copy link
Contributor

I`ve created a draft PR including only backend fixes.

@Agastya221
Copy link
Contributor

@csehatt741 Frontend is already done but since it's FossHacks issue We need to pr when the event starts

@csehatt741
Copy link
Contributor

Actually, that is another reason I created a draft PR, so you can also commit your changes into the same branch and have the PR ready only when FossHacks is opened.

@rajdip-b
Copy link
Member Author

Nah, drafts aren't allowed either. Yes you can save the changes in a branch, and save them for later for sure.

@csehatt741
Copy link
Contributor

Though, I`m not much interested in FOSSHack, but if it is important we can close this PR and create a new one later.

@csehatt741
Copy link
Contributor

I`ve finished working on the backend and can be unassigned from this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: 2 FOSSHack2025 FOSS Hack is scheduled from Feb 22 to Feb 23. FOSS-accepted issues would have this tag good first issue Good for newcomers priority: high scope: api Everything related to the API scope: platform Everything related to the keyshade platform package type: bug Something isn't working
Projects
None yet
4 participants