Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email validation error #695

Open
mohsenkhosroanjam opened this issue Feb 7, 2025 · 4 comments · May be fixed by #725
Open

Email validation error #695

mohsenkhosroanjam opened this issue Feb 7, 2025 · 4 comments · May be fixed by #725

Comments

@mohsenkhosroanjam
Copy link

Describe the bug
As a user, I can enter my email in the email box on the homepage to join the waitlist. If I leave the email box blank, the error:"Please enter a valid email address" is shown. If I enter an invalid email address, another error will be shown through the browser tooltip.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://keyshade.xyz/
  2. Leave the email box blank
  3. Click on "JOIN WAITLIST" button
  4. Enter an invalid email address
  5. Click on "JOIN WAITLIST" button

Expected behavior
In both cases, leaving the field blank and entering an invalid email address, the error:"Please enter a valid email address" is a good error message, and there is no need to show the error through the browser tooltip.

Screenshots

Image Image

Desktop (please complete the following information):

  • OS: [macOS]
  • Browser [Chrome]
  • Version [132.0.6834.111]
@rajdip-b
Copy link
Member

rajdip-b commented Feb 8, 2025

Image

I wasn't able to reproduce the bug you mentioned, but here's one bug that almost everyone might encounter after joining the waitlist.

  • There are two messages
  • The alignment is messed up

We would be glad if you could drop in a fix for this

@mohsenkhosroanjam
Copy link
Author

@rajdip-b Sure!
Can we have a separate issue for the bug you mentioned?
I am ready to send you a PR fixing the bug I mentioned. I will attach a video of the state before and after my changes to let you know how I changed the handling of the error message.

@mohsenkhosroanjam
Copy link
Author

mohsenkhosroanjam commented Feb 8, 2025

@rajdip-b
I am ready to send you my PR if you agree with the error in the case of an invalid email address.

Before my changes:

Screen.Recording.2025-02-08.at.7.23.42.PM.mov

After my changes:

Screen.Recording.2025-02-08.at.7.24.34.PM.mov

@rajdip-b
Copy link
Member

rajdip-b commented Feb 8, 2025

Yeah we can absolutely separate the issues.

I would just like to know if you want to put up a contribution for FOSS Hack. If yes, then I would need you to hold on to your PR.

P.S. i will link the other issue soon

@mohsenkhosroanjam mohsenkhosroanjam linked a pull request Feb 9, 2025 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants