Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: GitHub OAuth redirect not working #607

Closed
rajdip-b opened this issue Jan 9, 2025 · 11 comments · Fixed by #692
Closed

API: GitHub OAuth redirect not working #607

rajdip-b opened this issue Jan 9, 2025 · 11 comments · Fixed by #692
Assignees
Labels

Comments

@rajdip-b
Copy link
Member

rajdip-b commented Jan 9, 2025

Describe the bug

After signing up / logging in using github, we are not being redirected to the platform app.

To Reproduce
Steps to reproduce the behavior:

  1. Go to http://localhost:4200/api/auth/github
  2. Sign in using github credentials
  3. You are not redirected to the frontend app

Expected behavior

After authentication, the user should be redirected to the signin page of the platform app. Refer to the OAuth implementation of Google.

Screenshots

image

@rajdip-b rajdip-b added type: bug Something isn't working good first issue Good for newcomers scope: api Everything related to the API priority: high difficulty: 2 labels Jan 9, 2025
@csehatt741
Copy link
Contributor

/attempt

Copy link

Assigned the issue to @csehatt741!

@rajdip-b rajdip-b moved this to In progress in keyshade-api Jan 14, 2025
@csehatt741
Copy link
Contributor

It seems, it works for me as expected:

image

GITHUB_CALLBACK_URL env var and GitHub OAuth Apps/Authorization callback URL must match and both should point to the frontend app.

Could, you double check these settings, please?

@rajdip-b
Copy link
Member Author

thats weird, i'll double check this for sure

@csehatt741
Copy link
Contributor

@rajdip-b, could you clarify the issue, please?

@rajdip-b
Copy link
Member Author

The backend should be redirecting the users back to the signup screen after github oauth with a few details set in the query params. Last i checked, this wasnt happening. Auth was completed, but there was no redirection.

@rajdip-b
Copy link
Member Author

Image

As you can see, i tried again, but it failed.

@csehatt741
Copy link
Contributor

I cannot reproduce this issue locally and would rather not deal with it anymore.

@rajdip-b, could you unassign this issue from me, please?

@rajdip-b
Copy link
Member Author

Okay sure

@rajdip-b rajdip-b moved this from In progress to Todo in keyshade-api Jan 21, 2025
@rajdip-b rajdip-b self-assigned this Feb 7, 2025
@rajdip-b rajdip-b moved this from Todo to In progress in keyshade-api Feb 7, 2025
@github-project-automation github-project-automation bot moved this from In progress to Done in keyshade-api Feb 7, 2025
@rajdip-b rajdip-b moved this from Done to Queued for release in keyshade-api Feb 7, 2025
@rajdip-b
Copy link
Member Author

rajdip-b commented Feb 7, 2025

🎉 This issue has been resolved in version 2.11.0-stage.17 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@rajdip-b
Copy link
Member Author

🎉 This issue has been resolved in version 2.11.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@rajdip-b rajdip-b moved this from Queued for release to Done in keyshade-api Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants