Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Galaxie Greek/Hebrew (Mnemonic) Keyboard Package keyboard page shows "Not Found .js file" #525

Closed
1 of 8 tasks
Meng-Heng opened this issue Jan 3, 2025 · 0 comments · Fixed by #526
Closed
1 of 8 tasks

bug: Galaxie Greek/Hebrew (Mnemonic) Keyboard Package keyboard page shows "Not Found .js file" #525

Meng-Heng opened this issue Jan 3, 2025 · 0 comments · Fixed by #526
Assignees
@mcdurdin
Labels
bug Something isn't working
Milestone
A18S19

Comments

@Meng-Heng
Copy link
Collaborator

Meng-Heng commented Jan 3, 2025 •
edited
Loading

Describe the bug

Source of report: https://community.software.sil.org/t/cannot-find-keyboard-package/9602

I choose the following keyboard: Galaxie Greek/Hebrew (Mnemonic) Keyboard Package. The install page loads and immediately displays this message:
Image
Since I don’t know what else to do I click off this warning message and click on the green install button anyway.

Happens here too:
Image

  1. User misunderstand this message for an error.
  2. Could it be interfering with the proposed issue on the community site (link provided above)?

Reproduce the bug

  1. Go to the Keyboard/Package detail or help page via the links provided below.
  2. The Not found message appears.

Expected behavior

Stop displaying the Not Found .js file.

Related issues

No response

Keyman apps

  • Keyman for Android
  • Keyman for iPhone and iPad
  • Keyman for Linux
  • Keyman for macOS
  • Keyman for Windows
  • Keyman Developer
  • KeymanWeb
  • Other - give details at bottom of form

Keyman version

17.0.332

Operating system

Windows 10, Windows 11

Device

MacBook Pro, LG Gram

Target application

No response

Browser

Chrome

Keyboard name

galaxie_greek_hebrew_mnemonic

Keyboard version

3.4.1

Language name

Greek, Hebrew

Additional context
@Meng-Heng Meng-Heng added the bug Something isn't working label Jan 3, 2025
@mcdurdin mcdurdin mentioned this issue Jan 3, 2025
Closed
@mcdurdin mcdurdin transferred this issue from keymanapp/keyman Jan 4, 2025
@mcdurdin mcdurdin added this to the A18S19 milestone Jan 4, 2025
mcdurdin added a commit that referenced this issue Jan 4, 2025
@mcdurdin
fix: avoid error when jsFilename is missing or mismatches package id
2fb50c9 
Ensures that the keymanweb keyboard reference is correct for the
package, as it will not always match the package identifier, or may
not be available as a standalone keyboard. This then prevents the error
in #525 from presenting.

This fix works around a data issue documented in keymanapp/keyman#12853.

Fixes: #525
Relates-to: keymanapp/keyman#12853
@mcdurdin mcdurdin mentioned this issue Jan 4, 2025
Merged
@mcdurdin mcdurdin self-assigned this Jan 4, 2025
@github-project-automation github-project-automation bot moved this to Done in Keyman Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcdurdin mcdurdin

Labels
bug Something isn't working
Projects
Keyman
Archived in project
Milestone
A18S19
Development

Successfully merging a pull request may close this issue.

fix: avoid error when jsFilename is missing or mismatches package id keymanapp/keyman.com
2 participants
@mcdurdin @Meng-Heng