Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keras.ops.rot90 for tf.image.rot90 #20723

Open
innat opened this issue Jan 4, 2025 · 3 comments
Open

Add keras.ops.rot90 for tf.image.rot90 #20723

innat opened this issue Jan 4, 2025 · 3 comments
Assignees
Labels
type:feature The user is asking for a new feature.

Comments

@innat
Copy link

innat commented Jan 4, 2025

tf api: https://www.tensorflow.org/api_docs/python/tf/image/rot90
torch api: https://pytorch.org/docs/stable/generated/torch.rot90.html
jax api: https://jax.readthedocs.io/en/latest/_autosummary/jax.numpy.rot90.html

In keras, it provides RandomRotation and probably not replacable with tf.image.90.

@innat innat changed the title Add keras.ops.rot90* for tf.image.rot90 Add keras.ops.rot90 for tf.image.rot90 Jan 4, 2025
@fchollet
Copy link
Collaborator

fchollet commented Jan 4, 2025

It is a numpy op: https://numpy.org/doc/stable/reference/generated/numpy.rot90.html

Any op that is in numpy is in-scope for inclusion in Keras. Since there are already built-in functions for it in all backends, adding it should be easy. Are you able to open a PR?

@innat
Copy link
Author

innat commented Jan 4, 2025

I'm working on a related topic and can submit a PR if that helps.

@fchollet
Copy link
Collaborator

fchollet commented Jan 4, 2025

Please do.

@mehtamansi29 mehtamansi29 added the type:feature The user is asking for a new feature. label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature The user is asking for a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants