Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when skeuocard is positioned below the fold of the browser #115

Open
dylanjha opened this issue Dec 12, 2013 · 11 comments
Open

when skeuocard is positioned below the fold of the browser #115

dylanjha opened this issue Dec 12, 2013 · 11 comments

Comments

@dylanjha
Copy link
Contributor

on page load the browser scrolls to put the skeuocard into view

guessing this has to do with focusing the field automatically at instantiation time... digging around to try and confirm that hunch.

@dylanjha
Copy link
Contributor Author

confirmed... I think I would like an initialization option dontFocus: true, that would prevent focus on initialization. do you support that?

@frankfjf
Copy link

Having the same problem. Is there anyway to disable the initial autofocusing without breaking the other behavior of the form?

@dylanjha
Copy link
Contributor Author

I had to get this problem solved urgently, so I had a really nasty monkey patch you can see here:

mattnish/skeuocard-rails@ec7c295

I wouldn't recommend using this code, unless you're really in a bind.

I want to go back and make an actual fix for it, if I get around to it, I'll put in a PR

@frankfjf
Copy link

Thanks a lot. I might use this in the meantime since I also need it kind of urgently.

@dylanjha
Copy link
Contributor Author

dylanjha commented Jan 3, 2014

@kenkeiter are you still supporting this project? and what are your thoughts about an initialization options {dontFocus: true} ? If you support that as an enhancement, I'd be happy to give it a shot.

@kenkeiter
Copy link
Owner

I will be, yes -- sorry for the delay; I've recently joined a new company and haven't gotten back into the swing of giving my projects the attention they deserve.

The reason I haven't been accepting peoples' PRs is because they aren't reading the documentation which states (specifically) that all PRs must be submitted on the develop branch -- this is because master should always reflect a stable (production-ready) release :)

I've been operating under the assumption that people are simply cherry-picking the PRs they want and applying them to a fork, which seems like a good solution until I get around to correcting/merging all the PRs manually :)

@kenkeiter
Copy link
Owner

As an aside, @dylanjha, I really appreciate your effort on this project. I hope it's been useful to you. If you can submit a good PR on develop I'm more than happy to accept your enhancement :)

@dylanjha
Copy link
Contributor Author

dylanjha commented Jan 3, 2014

no problem. thanks for the reply. and thanks for this awesome library 👍 I'm loving it.

dylanjha added a commit to dylanjha/skeuocard that referenced this issue Jan 3, 2014
* defaults to false
* when this is true, skeuocard won't focus when itself on initialization
dylanjha added a commit to dylanjha/skeuocard that referenced this issue Jan 3, 2014
* defaults to false
* when this is true, skeuocard won't focus when itself on initialization
dylanjha added a commit to dylanjha/skeuocard that referenced this issue Jan 4, 2014
* defaults to false
* when true, prevents skeuocard from focusing itself when initialized
dylanjha added a commit to dylanjha/skeuocard that referenced this issue Jan 4, 2014
* defaults to false
* when true, prevents skeuocard from focusing itself when initialized
dylanjha added a commit to dylanjha/skeuocard that referenced this issue Jan 7, 2014
dylanjha added a commit to dylanjha/skeuocard that referenced this issue Jan 7, 2014
jackspirou added a commit that referenced this issue Jun 7, 2014
@argyleink
Copy link

awesome, this is a great new option

@dylanjha
Copy link
Contributor Author

dylanjha commented Oct 6, 2014

development should be merged into master @kenkeiter

@kenkeiter
Copy link
Owner

I'll get that done tonight! Thanks for the hard work, @dylanjha!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants