Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): topology incidents #2961

Open
wants to merge 44 commits into
base: main
Choose a base branch
from
Open

feat(api): topology incidents #2961

wants to merge 44 commits into from

Conversation

shahargl
Copy link
Member

@shahargl shahargl commented Jan 1, 2025 •
edited by talboren
Loading

close #2984

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jan 1, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 1, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 11:00am

@dosubot dosubot bot added API API related issues Feature A new feature labels Jan 1, 2025
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Jan 1, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 1, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 42.60870% with 66 lines in your changes missing coverage. Please review.

Project coverage is 31.23%. Comparing base (3e3a0e6) to head (d9c02c4).
Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
keep/api/core/db.py 12.19% 36 Missing ⚠️
keep/rulesengine/rulesengine.py 33.33% 16 Missing ⚠️
keep/api/bl/enrichments_bl.py 37.50% 5 Missing ⚠️
keep/api/models/alert.py 69.23% 4 Missing ⚠️
keep/api/bl/incidents_bl.py 0.00% 3 Missing ⚠️
keep/api/models/db/alert.py 93.75% 1 Missing ⚠️
keep/api/tasks/process_event_task.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #2961       +/-   ##
===========================================
- Coverage   43.52%   31.23%   -12.30%     
===========================================
  Files         165       70       -95     
  Lines       16250     7976     -8274     
===========================================
- Hits         7073     2491     -4582     
+ Misses       9177     5485     -3692

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
API API related issues Feature A new feature size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[➕ Feature]: Incident improvements
2 participants
@shahargl @talboren