-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lite Viz is too slow #2231
Comments
Installed kedro-viz on my env and without --lite it's work as expected. Problem seems to --lite flag only |
Hi @lordsoffallen , Thank you for raising the issue. Is it possible for you to give us a reproducible code snippet on which we can test and fix the issue. I am curious to know what were your import statements and dependencies (especially the file which has utf-8 dependency or related) |
@ravi-kumar-pilla Thanks, I would love to help but I have no idea where the problem is. This is a kedro project with many files inside. Is there like debug option that would output where the utf-8 errors are coming from? I don't know any file that i have that has something to do with utf-8. There are quite python in the project. |
I see, Thanks for the response @lordsoffallen . As of now we do not have a debug option to give you a better debugging experience. Based on the error stack trace I think the error is being thrown when we are trying to open a file in the project. We have the below code at with open(file_path, "r", encoding="utf-8") as file:
file_content = file.read() We can improve the error message to know exactly which file is causing the issue, but in the mean time if you would like to contribute, you can debug this file |
I can debug but I still don't see how i can invoke this in my IDE. What I normally do is:
Which will just run a node, not idea how to invoke viz programatically so i can step into those lines. Would it be possible to add debug line logs (as it would help debug further issues in the future directly) and then I can upgrade and just enable debug logs? This is not urgent for me btw as without --lite flag, it works for me. |
Hi @lordsoffallen , Sorry for the delay in response. The immediate next step for us would be to improve the error message, which shows the file causing issue. As per the info shared, it seems our FileParser is unable to decode a file which may be not UTF-8 encoded. I would be happy to jump on a call and see if we can place some debug statements to find the root cause. I am working in CST timezone. Please let me know a good time to connect with you. Thank you |
Unfortunately, it won't be possible anytime soon. Project env is a bit complex so I can't install kedro-viz into it which means I can't directly debug on my IDE. If I can find a time, I'll get back to you. |
okay, thanks for letting us know. We will add some logs to help understand the file causing issue in the next sprint. I hope it will narrow down the issue. I will update you after the next release. Thank you for trying |
But actually the interesting thing is that, after a while, it does start! Launched the command at So this isn't a case of "--lite doesn't work", but rather
|
So ERRORs should be warnings and simply we wait a bit more? Interesting turn of events 😆 |
Hi @astrojuanlu @lordsoffallen , The Also, ![]() Ideally it should not slow down the viz run but it may not improve the speed as well. I have included the file path in the error message in the new release which would narrow down the issue - #2266 . If the log level is confusing, we can make this a warning. wdyt ? Thank you |
For errors i expect code to fail at some point and if we don't, i think warnings makes more sense to me. Let me know when the log changes are released so i can also tell you which files were having issues. |
Hi @lordsoffallen , The file name is now included in the logs. Though it still shows log level as ERROR, we will make the log level to warning and also try to add a spinner in the future release. You can try kedro-viz 10.2.0 to check the file names. Thank you |
Description
I am running
uvx --with kedro-viz kedro viz run --lite
in a project to visualize the nodes but it's throwing the following errors:Context
Just trying to run the lite viz on my project.
Steps to Reproduce
Run the command above in a project.
Your Environment
Include as many relevant details as possible about the environment you experienced the bug in:
Checklist
The text was updated successfully, but these errors were encountered: