-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using secretRef for hashicorpVault auth #6143
Open
dttung2905
wants to merge
5
commits into
kedacore:main
Choose a base branch
from
dttung2905:hashicorp-vault-auth-from-secretref
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Allow using secretRef for hashicorpVault auth #6143
dttung2905
wants to merge
5
commits into
kedacore:main
from
dttung2905:hashicorp-vault-auth-from-secretref
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dttung2905
force-pushed
the
hashicorp-vault-auth-from-secretref
branch
2 times, most recently
from
October 28, 2024 22:53
0d3435c
to
bbae0b0
Compare
dttung2905
force-pushed
the
hashicorp-vault-auth-from-secretref
branch
from
November 11, 2024 21:37
59d5df0
to
dce9397
Compare
}, | ||
} | ||
vaultHandler := NewHashicorpVaultHandler(&vault) | ||
err := vaultHandler.Initialize(context.TODO(), nil, logf.Log.WithName("test"), "", nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: dttung2905 <[email protected]>
Signed-off-by: dttung2905 <[email protected]>
Signed-off-by: dttung2905 <[email protected]>
Signed-off-by: dttung2905 <[email protected]>
Signed-off-by: dttung2905 <[email protected]>
dttung2905
force-pushed
the
hashicorp-vault-auth-from-secretref
branch
from
January 14, 2025 23:04
0003f49
to
7d4775c
Compare
I see that you have pushed changes this week, are you still working or I can review it? |
@JorTurFer I think I'm done. Could you help to review it? So sorry I had a busy Christmas so I'm trying to work on the E2E test as you mentioned in the previous stand up |
dttung2905
changed the title
WIP: Allow using secretRef for hashicorpVault auth
Allow using secretRef for hashicorpVault auth
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow referring to a k8s secret that contain hashicorp Vault token. Similar to AzureKeyVault and AWSSecretManager https://keda.sh/docs/2.15/concepts/authentication/#re-use-credentials-and-delegate-auth-with-triggerauthentication
TODO
Checklist
Fixes #6026