From 8dca2cdee5cc95b7736d7599d42685e8adcb81da Mon Sep 17 00:00:00 2001 From: zajca Date: Thu, 5 Dec 2024 15:13:45 +0100 Subject: [PATCH] test same with SNFLK --- .../Snowflake/ImportTreatValuesAsNullTest.php | 44 ++++++++++++++----- 1 file changed, 34 insertions(+), 10 deletions(-) diff --git a/tests/Backend/Snowflake/ImportTreatValuesAsNullTest.php b/tests/Backend/Snowflake/ImportTreatValuesAsNullTest.php index 1a22bb8ac..63a51c754 100644 --- a/tests/Backend/Snowflake/ImportTreatValuesAsNullTest.php +++ b/tests/Backend/Snowflake/ImportTreatValuesAsNullTest.php @@ -53,7 +53,7 @@ public function testImportTreatValuesAsNull( return $row; }, $data); - $this->assertEqualsCanonicalizing($expectedData, $data); + $this->assertArraySameSorted($expectedData, $data, 0); } /** @@ -66,20 +66,20 @@ public function treatValuesAsNullData(): Generator 'expectedData' => [ 0 => [ 0 => '30', - 1 => 'armenia', - 2 => null, + 1 => 'armenia with null', + 2 => null, // col without enclosure is null by default 3 => 'b', ], 1 => [ 0 => '31', - 1 => 'belarus', + 1 => 'belarus with empty string', 2 => '', - 3 => 'b', + 3 => 'c', ], 2 => [ 0 => '32', 1 => 'malta', - 2 => 'a', + 2 => 'b', 3 => 'b', ], ], @@ -90,24 +90,48 @@ public function treatValuesAsNullData(): Generator 'expectedData' => [ 0 => [ 0 => '30', - 1 => 'armenia', + 1 => 'armenia with null', 2 => null, 3 => 'b', ], 1 => [ 0 => '31', - 1 => 'belarus', + 1 => 'belarus with empty string', 2 => null, - 3 => 'b', + 3 => 'c', ], 2 => [ 0 => '32', 1 => 'malta', - 2 => 'a', + 2 => 'b', 3 => 'b', ], ], ]; + yield 'string' => [ + 'importedFile' => __DIR__ . '/../../_data/languages-empty-string.csv', + 'expectedData' => [ + 0 => [ + 0 => '30', + 1 => 'armenia with null', + 2 => null, // col without enclosure is null by default + 3 => null, + ], + 1 => [ + 0 => '31', + 1 => 'belarus with empty string', + 2 => '', + 3 => 'c', + ], + 2 => [ + 0 => '32', + 1 => 'malta', + 2 => null, + 3 => null, + ], + ], + 'treatValuesAsNull' => ['b'], + ]; } private function createTable(string $tableName): string