Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RangeError: too many function arguments #5

Open
jrmuizel opened this issue Dec 20, 2022 · 2 comments
Open

RangeError: too many function arguments #5

jrmuizel opened this issue Dec 20, 2022 · 2 comments

Comments

@jrmuizel
Copy link
Contributor

I get this when try to use canvas-rr on Google Meet with a virtual background.

RangeError: too many function arguments
    encode blob:https://meet.google.com/412a6d21-7795-4cd2-b8ff-b9c01ce47724:124
    snapshot_if_array_buffer blob:https://meet.google.com/412a6d21-7795-4cd2-b8ff-b9c01ce47724:156
    snapshot_str blob:https://meet.google.com/412a6d21-7795-4cd2-b8ff-b9c01ce47724:261
    pickle_obj blob:https://meet.google.com/412a6d21-7795-4cd2-b8ff-b9c01ce47724:310
    pickle_arg blob:https://meet.google.com/412a6d21-7795-4cd2-b8ff-b9c01ce47724:356
    args blob:https://meet.google.com/412a6d21-7795-4cd2-b8ff-b9c01ce47724:365
    pickle_call blob:https://meet.google.com/412a6d21-7795-4cd2-b8ff-b9c01ce47724:365
    fn_observe blob:https://meet.google.com/412a6d21-7795-4cd2-b8ff-b9c01ce47724:539
    value blob:https://meet.google.com/412a6d21-7795-4cd2-b8ff-b9c01ce47724:482
    _glBufferData https://meet.google.com/_/rtcvidproc/release/495207330/videopipe_bundle.js:261
@jrmuizel
Copy link
Contributor Author

apply() suffers the same problem.

I tried const dec_bstr = dec_u8a.reduce((string, val) => string + String.fromCodePoint(val), ''); instead and it seemed to work but was still very slow. I'll probably try https://github.com/lucacasonato/proposal-binary-encoding/blob/main/polyfill/mod.mjs next.

@jrmuizel
Copy link
Contributor Author

That's still too slow. I also tried https://github.com/mitschabaude/fast-base64/blob/main/js.js and it's still a pretty big bottleneck. I wonder if it makes sense to send the buffers to a worker and have it do the encoding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant