-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deletion variant not called #125
Comments
Hi @swomics, |
Hi @swomics, However, there was also a bug which was overriding min-support = 1, and preventing any calls! The bug should now be fixed. It will be a few days before a proper release, but you can download one of the pre-built wheels from the workflow page when they finish building https://github.com/kcleal/dysgu/actions/runs/13658034481 |
* Dysgu_dev <-- master (#121) * Dysgu dev (#115) * dysgu_dev <- master (#108) * correct usage of update_filter_value in filter_normals It seems like at some point the usage of update_filter_value changed, because in several spots, it is missing the sample_name argument. This breaks `dysgu filter --keep-all`. * Update main.yml * Update main.yml * Update requirements.txt * updated build process to pyproject.toml (#103) * v1.6.6 updated README * Update main.yml * Added pyproject.toml * Updated pyproject.toml and setup.py * Update pyproject.toml --------- Co-authored-by: Dr. K. D. Murray <[email protected]> * Better recall+precision for long-reads. Improved merging pipeline. Faster runtime. Code refactoring. WIP # [skip ci] * Fixed issues with overriding presets. --mode option updated # [skip ci] * Fixed issues with overriding presets. --mode option updated to support r10 and revio, new presets available. --no-gt flat removed # [skip ci] * Fixed CLI issues for tests # [skip ci] * Fixed API issue * v1.7.0 * added deprecated warning for mode * Added filter for high divergence reads (long-reads only) # [skip ci] * Better read merging for long reads. New clustering methods for long reads. Improved runtime. * Update main.yml * Update main.yml * Update osx-deps * Update main.yml macos11 * Update main.yml * Update main.yml * Update main.yml * Update osx-deps * Update osx-deps * Update osx-deps * Update osx-deps * Update main.yml * Update osx-deps * Update main.yml * Updated workflow * Updated workflow * Updated workflow * Update main.yml * Updated workflow --------- Co-authored-by: Dr. K. D. Murray <[email protected]> * Fixes compile error for clang * Fixed merge None type error. Added wb3 as default compression level for long-reads (run-pipeline) (#116) * Updated workflow * Updated workflow * Fixed compiler warning --------- Co-authored-by: Dr. K. D. Murray <[email protected]> * Fixed compile errors. Add logging for HP tag usage * Added superintervals dependency * Added PSET phaseset HP haplotype tag and AF allele frequency tags to output * Fixed index error * Changed empty PSET and HP to 0 * PSET and HP default to empty string * PSET and HP default to '-1' and '0' * #125 better calling of low support SVs * #125 better calling of low support SVs * Updated requirements.txt --------- Co-authored-by: Dr. K. D. Murray <[email protected]>
Thank you for such a quick response! I will try again tomorrow and see if the divergence parameter gets the behaviour I was looking for. |
No problem. I recommend getting the update though. You can download wheels for Mac or Linux here https://github.com/kcleal/dysgu/actions/runs/13658034481. These can be unzipped and installed using |
Hello, I've tried again with the new build, divergence 0.2, min-support 2 & min-support 1 and it is still giving me the same behaviour (nothing called for the known SV with min-support 2 and very low quality candidate with no_call at min-support 1) |
* Dysgu_dev <-- master (#121) * Dysgu dev (#115) * dysgu_dev <- master (#108) * correct usage of update_filter_value in filter_normals It seems like at some point the usage of update_filter_value changed, because in several spots, it is missing the sample_name argument. This breaks `dysgu filter --keep-all`. * Update main.yml * Update main.yml * Update requirements.txt * updated build process to pyproject.toml (#103) * v1.6.6 updated README * Update main.yml * Added pyproject.toml * Updated pyproject.toml and setup.py * Update pyproject.toml --------- Co-authored-by: Dr. K. D. Murray <[email protected]> * Better recall+precision for long-reads. Improved merging pipeline. Faster runtime. Code refactoring. WIP # [skip ci] * Fixed issues with overriding presets. --mode option updated # [skip ci] * Fixed issues with overriding presets. --mode option updated to support r10 and revio, new presets available. --no-gt flat removed # [skip ci] * Fixed CLI issues for tests # [skip ci] * Fixed API issue * v1.7.0 * added deprecated warning for mode * Added filter for high divergence reads (long-reads only) # [skip ci] * Better read merging for long reads. New clustering methods for long reads. Improved runtime. * Update main.yml * Update main.yml * Update osx-deps * Update main.yml macos11 * Update main.yml * Update main.yml * Update main.yml * Update osx-deps * Update osx-deps * Update osx-deps * Update osx-deps * Update main.yml * Update osx-deps * Update main.yml * Updated workflow * Updated workflow * Updated workflow * Update main.yml * Updated workflow --------- Co-authored-by: Dr. K. D. Murray <[email protected]> * Fixes compile error for clang * Fixed merge None type error. Added wb3 as default compression level for long-reads (run-pipeline) (#116) * Updated workflow * Updated workflow * Fixed compiler warning --------- Co-authored-by: Dr. K. D. Murray <[email protected]> * Fixed compile errors. Add logging for HP tag usage * Added superintervals dependency * Added PSET phaseset HP haplotype tag and AF allele frequency tags to output * Fixed index error * Changed empty PSET and HP to 0 * PSET and HP default to empty string * PSET and HP default to '-1' and '0' * #125 better calling of low support SVs * #125 better calling of low support SVs * Updated requirements.txt * Fixed large record output, switched to symbolic --------- Co-authored-by: Dr. K. D. Murray <[email protected]>
Ok, sorry about that. Would you be able to share the vcf file for that record? And if possible the log output for dysgu? Thanks |
Using the test data you sent, dysgu found a 3 SVs - are these the ones you were expecting?
|
Here are the outputs, perhaps it's the difference in the parameters? Initially I ran with the sequel2 flag (it's older HiFi data), but I had the same issue. 2025-03-06 11:01:30,936 [INFO ] [dysgu-run] Version: 1.8.1 FR989875.1 12257853 190306 T <DEL> . lowProb SVMETHOD=DYSGUv1.8.1;SVTYPE=DEL;END=12259528;CHR2=FR989875.1;GRP=190306;NGRP=1;CT=3to5;CIPOS95=0;CIEND95=0;SVLEN=1675;CONTIGA=ATAAAAAATATTAATATCCATTAATTTAAATACATGATTGCAAATGTGGTGCATATGCGTGTATTATACATATAAACTTTCCCCTTGAACCACTTTGTCTATTGATGGAAACCGCATTAAAATCCGTTGCGTAGTTTAAAAGATCTAAGCGTACAGATGGCGGGAAGCGTTAGACACAGTTCAACAATTTATCAACTCTGGCAGCAGTCAGTACTGGATAAGGCCGTAGTACGTCTTATTTTTGGATCAT;KIND=extra-regional;GC=35.6;NEXP=0;STRIDE=0;EXPSEQ=;RPOLY=21;OL=0;SU=2;WR=1;PE=0;SR=0;SC=0;BND=0;LPREC=1;RT=pacbio GT:GQ:PSET:HP:AF:MAPQP:MAPQS:SU:WR:PE:SR:SC:BND:NMB:COV:NEIGH10:PS:MS:RMS:RED:BCC:FCC:ICN:OCN:PROB ./.:.:-1:0:1.0:60.0:0.0:2:1:0:0:0:0:1.17:0.0:26:1:0:0:0:0:-1.0:-1.0:-1.0:0.249 |
Yes, it is the 1675 deletion that I would like to call and genotype in short read sets. |
Its a little unclear what is going wrong here. If you run the test sample you sent me, does dysgu 1.8.1 now find the SV in question? I think I might need another large test bam file to reproduce the issue. Thanks! |
If I run the command as above dysgu call --divergence 0.2 --symbolic-sv-size 0 --mode pacbio-revio ../../Sanger_genome2/GCA_905404145.2_ilBisBetu1.2_genomic.fna wd test.bam -x |
Thats odd, I think that bit of code has been replaced in a newer build already. Would you mind testing with the latest build of v1.8.1 found here: https://github.com/kcleal/dysgu/actions/runs/13679919289 Thanks again. |
Hi, I'm trying to call a verified deletion variant using some low coverage HiFi reads. I have to reduce the min-support to 1 for it to be identified in the output. However it appears as two records and is not called, whereas other indels with the same coverage seem to be called correctly. I've attached a small subset of the bam and vcf for the region, in case that helps
test.zip
The text was updated successfully, but these errors were encountered: