Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Metadata and Resources sections to the editor's setup screen #2316

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

CloneWith
Copy link
Contributor

Metadata and resource editing are essential features for a beatmap, and adding them should be fine.
Also changing the items' type to Drawable so it's convenient to "group" sections together with FillFlowContainer or something else X)

@andy840119
Copy link
Member

https://github.com/ppy/osu/blob/master/osu.Game.Rulesets.Osu/OsuRuleset.cs#L343-L363
https://github.com/ppy/osu/blob/master/osu.Game.Rulesets.Taiko/TaikoRuleset.cs#L195-L198

Seems other rulesets add this section also.

Copy link
Member

@andy840119 andy840119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LG™
Please fix the issue by suggestion.
And the CI broken can ignore now.

@andy840119 andy840119 merged commit 2605dae into karaoke-dev:master Jan 20, 2025
3 of 5 checks passed
@CloneWith CloneWith deleted the feature/setup-sections branch January 21, 2025 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants