Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Funky Authorization #5

Open
odino opened this issue Feb 15, 2018 · 2 comments
Open

Funky Authorization #5

odino opened this issue Feb 15, 2018 · 2 comments

Comments

@odino
Copy link

odino commented Feb 15, 2018

Hi @kameshsampath -- great work here!

I was wondering how did you manage to make sure that the Authorization header is present to allow the request? I've setup a similar repo but:

  • if I use (request.headers["authorization"]|"unauthorized") == "unauthorized" then requests with a valid token get rejected (I suspect because the JWT auth listener removes the Authorization header altogether)
  • with request.headers["authorization"] == "unauthorized" requests with no Authorization header go through

Any idea? I think you faced something similar (mentioned here) but it's not clear to me how you solved it.

@kameshsampath
Copy link
Owner

@odino - which version of Istio ?? I just used this https://github.com/kameshsampath/istio-keycloak-demo/blob/master/cars-api/src/istio/mixer-rule-only-authorized.yaml ( this version seem to be stable for me with Istio 0.5.0) for adding the authorization check ideally this suited for demo purposes from various Istio Security threads I did see that they are refactoring the JWT - not sure something might be broken in new version . Can check and tell.

with request.headers["authorization"] == "unauthorized" requests with no Authorization header go through
thats the expected behaviour

CC: @sebastienblanc

@odino
Copy link
Author

odino commented Feb 15, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants