You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I dislike storing the blobs in this repo. Also I dislike using any CLI tools to generate them. Yes it tests compatibility to CLI tools, but there are some issues.
Today I have implemented the tests for Improved python module architecture and added algos. #2 and saw that zstd tests don't pass. It turned out the tests files are incompatible to the current version (I have not tested against old ones). I have regenerated them with the recent version and everything has started passing.
lzma (lzma version 1, alone format) files also don't work IDK why.
testing files are binary which don't suit well for git.
testing files don't align with Kaitai Struct use case well. KS is used to parse custom binary formats, in these formats compressed streams are achieved not by calling CLI utilities but by using API of the libs.
So I propose to get rid of all of the testing files (and remove them from history) and instead generate some random data in runtime, compress it using the interface for serialization I have introduced and then decompress and verify that the decompressed stream matches the original one. I have implemented only python part of serializing interface because I don't use node.js and Ruby.
If you prefer to keep them ... probably they should be moved to LFS rewriting all the history.
The text was updated successfully, but these errors were encountered:
I dislike storing the blobs in this repo. Also I dislike using any CLI tools to generate them. Yes it tests compatibility to CLI tools, but there are some issues.
Today I have implemented the tests for Improved python module architecture and added algos. #2 and saw that zstd tests don't pass. It turned out the tests files are incompatible to the current version (I have not tested against old ones). I have regenerated them with the recent version and everything has started passing.
lzma (lzma version 1,
alone
format) files also don't work IDK why.testing files are binary which don't suit well for git.
testing files don't align with Kaitai Struct use case well. KS is used to parse custom binary formats, in these formats compressed streams are achieved not by calling CLI utilities but by using API of the libs.
So I propose to get rid of all of the testing files (and remove them from history) and instead generate some random data in runtime, compress it using the interface for serialization I have introduced and then decompress and verify that the decompressed stream matches the original one. I have implemented only python part of serializing interface because I don't use node.js and Ruby.
If you prefer to keep them ... probably they should be moved to LFS rewriting all the history.
The text was updated successfully, but these errors were encountered: