Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PebbleDB support #42

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Add PebbleDB support #42

merged 2 commits into from
Jul 29, 2024

Conversation

junha-ahn
Copy link
Contributor

@junha-ahn junha-ahn commented Jul 7, 2024 •
edited
Loading

Proposed changes

  • Add PebbleDB as a new database option for the project.

Types of changes

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have read the CLA and signed by comment I have read the CLA Document and I hereby sign the CLA in first time contribute
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

@junha-ahn junha-ahn mentioned this pull request Jul 7, 2024
Closed
9 tasks
@blukat29 blukat29 changed the title add Pebble DB Add PebbleDB support Jul 9, 2024
@blukat29
Copy link
Contributor

blukat29 commented Jul 9, 2024

@junha-ahn Thanks for the contribution. Please run cd storage/database && gci -w pebbledb_database.go and push again to fix the test-linter. You can install gci with go install github.com/daixiang0/gci@latest.

@blukat29
Copy link
Contributor

blukat29 commented Jul 9, 2024

Thanks. Let us merge it after 1.0.1 release.

@blukat29 blukat29 added the do not merge Do not merge just yet label Jul 9, 2024
@blukat29 blukat29 removed the do not merge Do not merge just yet label Jul 25, 2024
@blukat29 blukat29 merged commit e8a0faa into kaiachain:dev Jul 29, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hyeonLewis hyeonLewis hyeonLewis approved these changes

@yoomee1313 yoomee1313 yoomee1313 approved these changes

@blukat29 blukat29 blukat29 approved these changes

@sjnam sjnam Awaiting requested review from sjnam

@ian0371 ian0371 Awaiting requested review from ian0371 ian0371 is a code owner

@aidan-kwon aidan-kwon Awaiting requested review from aidan-kwon

@jeongkyun-oh jeongkyun-oh Awaiting requested review from jeongkyun-oh

@hyunsooda hyunsooda Awaiting requested review from hyunsooda

@2dvorak 2dvorak Awaiting requested review from 2dvorak

@kjeom kjeom Awaiting requested review from kjeom

@JayChoi1736 JayChoi1736 Awaiting requested review from JayChoi1736

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@junha-ahn @blukat29 @yoomee1313 @hyeonLewis