Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring geth updates for EIP-7623 #200

Merged
merged 8 commits into from
Jan 8, 2025

Conversation

2dvorak
Copy link
Contributor

@2dvorak 2dvorak commented Jan 7, 2025

Proposed changes

  • This PR tries to bring geth implementation for EIP-7623.
  • Relevant tests will be added in a separate PR.

We have different IntrinsicGas implementations for different TxType.
Some tx types need to handle intrinsic gas, and some don't.
The former types are affected by EIP-7623 thus they are updated to handle dataTokens in this PR.

List of tx types that handle dataToken List of tx types that return 0 for dataToken
ChainDataAnchoring
EthereumAccessList
EthereumDynamicFee
EthereumSetCode
FeeDelegatedChainDataAnchoringWithRatio
FeeDelegatedChainDataAnchoring
FeeDelegatedSmartContractDeployWithRatio
FeeDelegatedSmartContractDeploy
FeeDelegatedSmartContractExecutionWithRatio
FeeDelegatedSmartContractExecution
FeeDelegatedValueTransferMemoWithRatio
FeeDelegatedValueTransferMemo
Legacy
SmartContractDeploy
SmartContractExecution
ValueTransferMemo
AccountCreation
AccountUpdate
Cancel
FeeDelegatedAccountUpdateWithRatio
FeeDelegatedAccountUpdate
FeeDelegatedCancelWithRatio
FeeDelegatedCancel
FeeDelegatedValueTransferWithRatio
FeeDelegatedValueTransfer
ValueTransfer

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have read the CLA and signed by comment I have read the CLA Document and I hereby sign the CLA in first time contribute
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

Refer to ethereum/go-ethereum#30946.
That PR is ongoing so we may need further updates.
@2dvorak 2dvorak self-assigned this Jan 7, 2025
@2dvorak 2dvorak requested a review from ulbqb January 7, 2025 07:01
@ulbqb
Copy link
Contributor

ulbqb commented Jan 7, 2025

You should update execution-spec-test to solve the failure of ci test-tests. You can refer to this for updating execution-spec-test.

@ulbqb
Copy link
Contributor

ulbqb commented Jan 7, 2025

This commit wasn't required.

@2dvorak 2dvorak force-pushed the 2dvorak/eip7623-calldata-cost branch 2 times, most recently from c6e2573 to 451aae1 Compare January 7, 2025 09:12
@2dvorak 2dvorak force-pushed the 2dvorak/eip7623-calldata-cost branch from 451aae1 to 84afa5b Compare January 7, 2025 13:42
Co-authored-by: Yunjong Jeong (ollie) <[email protected]>
Copy link
Contributor

@blukat29 blukat29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As a follow-up,

  • Add EIP-7623 unit tests (tx_gas_calculation_test.go)
  • Fix frontier state_test cases

blockchain/system/multicall.go Outdated Show resolved Hide resolved
@2dvorak 2dvorak marked this pull request as ready for review January 8, 2025 04:15
@2dvorak
Copy link
Contributor Author

2dvorak commented Jan 8, 2025

@blukat29 @hyeonLewis Thanks for the review, however I just updated the PR description with the tx types that handles dataTokens or simply return 0. Could you take a look?
If it seems fine, please leave a thumbs-up emoji.

@blukat29 blukat29 mentioned this pull request Jan 8, 2025
11 tasks
@2dvorak 2dvorak requested review from hyeonLewis and blukat29 January 8, 2025 04:22
tests/state_test.go Outdated Show resolved Hide resolved
@ulbqb ulbqb self-requested a review January 8, 2025 07:07
@blukat29 blukat29 merged commit 2f5633c into kaiachain:dev Jan 8, 2025
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2025
@2dvorak 2dvorak deleted the 2dvorak/eip7623-calldata-cost branch January 8, 2025 12:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants