-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring geth updates for EIP-7623 #200
Conversation
Refer to ethereum/go-ethereum#30946. That PR is ongoing so we may need further updates.
You should update execution-spec-test to solve the failure of ci test-tests. You can refer to this for updating execution-spec-test. |
This commit wasn't required. |
c6e2573
to
451aae1
Compare
451aae1
to
84afa5b
Compare
Co-authored-by: Yunjong Jeong (ollie) <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. As a follow-up,
- Add EIP-7623 unit tests (tx_gas_calculation_test.go)
- Fix frontier state_test cases
Co-authored-by: Lewis <[email protected]>
@blukat29 @hyeonLewis Thanks for the review, however I just updated the PR description with the tx types that handles |
Co-authored-by: Chihyun Song <[email protected]>
Proposed changes
We have different
IntrinsicGas
implementations for differentTxType
.Some tx types need to handle intrinsic gas, and some don't.
The former types are affected by EIP-7623 thus they are updated to handle
dataTokens
in this PR.dataToken
0
fordataToken
EthereumAccessList
EthereumDynamicFee
EthereumSetCode
FeeDelegatedChainDataAnchoringWithRatio
FeeDelegatedChainDataAnchoring
FeeDelegatedSmartContractDeployWithRatio
FeeDelegatedSmartContractDeploy
FeeDelegatedSmartContractExecutionWithRatio
FeeDelegatedSmartContractExecution
FeeDelegatedValueTransferMemoWithRatio
FeeDelegatedValueTransferMemo
Legacy
SmartContractDeploy
SmartContractExecution
ValueTransferMemo
AccountUpdate
Cancel
FeeDelegatedAccountUpdateWithRatio
FeeDelegatedAccountUpdate
FeeDelegatedCancelWithRatio
FeeDelegatedCancel
FeeDelegatedValueTransferWithRatio
FeeDelegatedValueTransfer
ValueTransfer
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
I have read the CLA Document and I hereby sign the CLA
in first time contribute$ make test
)Related issues