Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update max commission rate of public delegation #18

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

hyeonLewis
Copy link
Contributor

Proposed changes

Allow 100% commission rate for public delegation.

TODO: Deploy public delegation factory accordingly.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the [ ] I have read the CONTRIBUTING GUIDELINES doc
  • I have read the CLA and signed by comment I have read the CLA Document and I hereby sign the CLA in first time contribute
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link

github-actions bot commented Jun 21, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@hyeonLewis
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@hyeonLewis hyeonLewis force-pushed the pd-commission-rate branch from c02bab4 to 30ffe48 Compare June 21, 2024 04:45
@blukat29 blukat29 added the do not merge Do not merge just yet label Jun 21, 2024
@blukat29 blukat29 added this pull request to the merge queue Jun 29, 2024
@blukat29 blukat29 removed this pull request from the merge queue due to the queue being cleared Jun 29, 2024
@blukat29 blukat29 removed the do not merge Do not merge just yet label Jul 2, 2024
@blukat29 blukat29 changed the base branch from dev to queue/v1.0.1 July 2, 2024 01:23
@blukat29 blukat29 merged commit ec429a7 into queue/v1.0.1 Jul 2, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2024
@blukat29 blukat29 deleted the pd-commission-rate branch July 2, 2024 10:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants