-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blockchain: implement EIP-2935 #121
Conversation
index zero and removal of introduced `ChainContext`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In PR Usage comments, the output seems not a block hash for 20333. Could you recheck this?
> kaia.call({to:"0x0eF71b533f074383A14696f7EeBD94446b10F679", data:"0x6b2fafa90000000000000000000000000000000000000000000000000000000000004f6d"}) // getHash(20333)
> 0x6b2fafa90000000000000000000000000000000000000000000000000000000000004f6d // <- It seems data for eth_call, not block hash at 20333.
@hyeonLewis Thank you. Typo fixed. |
Currently, onboarding EIP-2935 requires additional modifications at the core level, specifically for:
Other changes involve deployment, but the provided artifact appears non-deployable (the signature value seems invalid). Once the artifact stabilizes, I’ll test it again. cc. @blukat29 |
Proposed changes
The main function has been implemented, but a task has been queued to simplify the history store callsite.
c1714134
(implement the main function)b38c8f2
(simplify the historical store callsite)Contract Deployment Process
According to EIP-2935 deployment transaction artifact, the code below generate the exact same system history storage address.
Usage
Once deployed, retrieval works like below:
Implementation details
consensus.Engine.Initialize()
that performs pre-block state transitions.(start, end]
num
tx
in blocknum
-- unchangedtx
at the end of the blocknum
, not the beginning ofnum+1
-- unchangedTypes of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
I have read the CLA Document and I hereby sign the CLA
in first time contribute$ make test
)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...