Audit: Error while creating an audit topic

[Haarolean]

2024-04-04 21:51:23,246 ERROR [restartedMain] i.k.u.s.a.AuditService: Error creating topic '__kui-audit-log'
org.apache.kafka.common.errors.InvalidConfigurationException: Unknown topic config name: 0.retention.ms

Perhaps, topic params present in AuditService#DEFAULT_AUDIT_TOPIC_CONFIG are not parsed properly.

[abhishekray323]

Hi,
can I start working on this issue? I think the triage is completed for this issue.

[abhishekray323]

Hi,
I am trying to work on this issue, but struggling in some basics like connecting kafka-ui to kafka broker, since I am new to it.
As I am new, it might take me quite a bit longer time than normal . I want to ask how long can I take to work on this issue, is there any timeline which I should be aware of about this issue?

[Haarolean]

@abhishekray323 you could run dev compose (https://github.com/kafbat/kafka-ui/blob/main/.dev/dev_arm64.yaml) and adjust the config to enable audit.
That's aight, take your time.

[abhishekray323]

I am not able to reproduce this issue.

The yaml file you mentioned in above comment doesn't exist anymore. Is there any other config for which this issue is happening?

[Haarolean]

@abhishekray323 it's been renamed: https://github.com/kafbat/kafka-ui/blob/main/.dev/dev.yaml
besides, you still need to adjust the config to add audit properties.
https://ui.docs.kafbat.io/configuration/audit-log

[abhishekray323]

@Haarolean
Adding following property to docker-compose is reproducing the issue:
KAFKA_CLUSTERS_0_AUDIT_AUDITTOPICPROPERTIES_0_RETENTION_MS: 43200000

reproduces the issue.

This is because auditTopicProperties is map, Map<String, String> auditTopicProperties;
And removing the index from audit topic properties solves the issue
KAFKA_CLUSTERS_0_AUDIT_AUDITTOPICPROPERTIES_RETENTION_MS: 43200000

But still here are some questions I want to ask:
1.) How interfaces can implement method of parent interface like here?

2.) Can you list down some resources on how to create kafka brokers / cluster using environment variable, I am not able to understand it completely? Tried to find on internet but can't find a detailed resource about it.

[Haarolean]

@abhishekray323
Ah, I guess this applies only when env vars are used and in the wrong way (list instead of a map). So the implementation seems to be correct.

Regarding your questions:

1. this package contains implementations of the interface you mentioned.
2. env vars and yaml config are interchangeable. This might help

I guess we should close this now, what do you think?

[abhishekray323]

Yeah, we should close this issue.
Just one more thing, I think the hyphen in " - retention.ms: 43200000" in this doc , makes it look like it's list . So, we should remove hyphen to avoid confusion.