Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brokers: Wrong 'Online partition count' value #526

Open
4 tasks done
abhirathod95 opened this issue Aug 21, 2024 · 6 comments · May be fixed by #607
Open
4 tasks done

Brokers: Wrong 'Online partition count' value #526

abhirathod95 opened this issue Aug 21, 2024 · 6 comments · May be fixed by #607
Assignees
@bachmanity1
Labels
area/brokers Broker / broker configs related issues scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/bug Something isn't working
Milestone
1.2

Comments

@abhirathod95
Copy link

abhirathod95 commented Aug 21, 2024 •
edited
Loading

Issue submitter TODO list

  • I've looked up my issue in FAQ
  • I've searched for an already existing issues here
  • I've tried running main-labeled docker image and the issue still persists there
  • I'm running a supported version of the application which is listed here

Describe the bug (actual behavior)

Kafka UI used to show the actual partition count per broker in the "Online Partitions" column under "Brokers" tab. After upgrading to v1.0.0, each broker row shows the total number of online partitions instead. Weirdly, the "partition skew" calculations are still accurate.

For example take a balanced cluster with 178 partitions, rep factor of 3, and 4 brokers. There are a total of 534 replicas in the cluster and each broker row in the table should show 133 or 134 online partitions. However, all of the rows are showing 178.

Expected behavior

Each broker should show the correct number of online partition replicas it holds. Given the example above, it should be 133 or 134 per broker.

Your installation details

I'm using v1.0.0 with a generic config file, nothing unique.

Steps to reproduce

Deploy kafka ui and link it to any cluster. I've tried it with 4 different clusters and they all show the same thing.

Screenshots

No response

Logs

No response

Additional context

No response
@abhirathod95 abhirathod95 added status/triage Issues pending maintainers triage type/bug Something isn't working labels Aug 21, 2024
@kapybro kapybro bot added status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Aug 21, 2024
@github-actions GitHub Actions
Copy link

Hi abhirathod95! 👋

Welcome, and thank you for opening your first issue in the repo!

Please wait for triaging by our maintainers.

As development is carried out in our spare time, you can support us by sponsoring our activities or even funding the development of specific issues.
Sponsorship link

If you plan to raise a PR for this issue, please take a look at our contributing guide.

@bachmanity1
Copy link
Contributor

Hi @Haarolean,

We're encountering the exact same issue - each broker row is displaying the total number of online partitions, rather than showing only the partitions located on that specific broker.

Could you please take a look at this?

image

@Haarolean
Copy link
Member

TODO:
Rather than setting 'online partitions' column value to onlinePartitionCount field value from cluster info, use the field partitionsLeader from broker info.

@Haarolean Haarolean added scope/frontend Related to frontend changes area/brokers Broker / broker configs related issues and removed status/triage/manual Manual triage in progress labels Oct 10, 2024
@Haarolean Haarolean changed the title Online partition count per brokers is inaccurate Brokers: Wrong 'Online partition count' value Oct 10, 2024
@Haarolean Haarolean added this to the 1.1 milestone Oct 10, 2024
@bachmanity1
Copy link
Contributor

Rather than setting 'online partitions' column value to onlinePartitionCount field value from cluster info, use the field partitionsLeader from broker info.

I think it should be just partitions rather than partitionsLeader.

@Haarolean
Copy link
Member

I think it should be just partitions rather than partitionsLeader.

why?

@bachmanity1
Copy link
Contributor

why?

I believe the partitionsLeader field represents the number of leaders located on a particular broker, and this information is already displayed in the Leaders column. The partitions field, on the other hand, reflects the number of partitions on a broker, so it would make more sense to use this value for the Online Partitions column.

@bachmanity1 bachmanity1 linked a pull request Oct 13, 2024 that will close this issue
Open
13 tasks
@Haarolean Haarolean assigned bachmanity1 and unassigned Nilumilak Dec 5, 2024
@Haarolean Haarolean moved this from Todo to In Review in Release 1.1 Dec 5, 2024
@Haarolean Haarolean removed this from the 1.1 milestone Dec 31, 2024
@Haarolean Haarolean removed this from Release 1.1 Dec 31, 2024
@Haarolean Haarolean added this to the 1.2 milestone Dec 31, 2024
@Haarolean Haarolean moved this to Todo in Release 1.2 Dec 31, 2024
@Haarolean Haarolean moved this from Todo to In Review in Release 1.2 Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bachmanity1 bachmanity1

Labels
area/brokers Broker / broker configs related issues scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/bug Something isn't working
Projects
Release 1.2
Status: In Review
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

FE: Fix 'Online Partitions' column bachmanity1/kafka-ui
4 participants
@Haarolean @abhirathod95 @bachmanity1 @Nilumilak