Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate section for solidity < 0.8.0 #102

Open
devtooligan opened this issue Feb 3, 2025 · 1 comment
Open

separate section for solidity < 0.8.0 #102

devtooligan opened this issue Feb 3, 2025 · 1 comment

Comments

@devtooligan
Copy link

Some older vulns like Uninitialized Storage Pointer are no longer applicable and should be excluded from the main sections and put in their own separate section for solidity < 0.8.0

If you're interested in this idea I can take a stab at a pr.

@kadenzipfel
Copy link
Owner

Currently there should be a warning on deprecated vulnerabilities, e.g. https://github.com/kadenzipfel/smart-contract-vulnerabilities/blob/master/vulnerabilities/incorrect-constructor.md, although some may be missing

My only concern with this approach is that some <0.8.0 vulns are still worth learning in case you're reviewing an old codebase so I wouldn't necessarily want people to skip over them

Maybe the best approach is to have a * next to them in the readme or something like that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants