Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.26] - Helm CRDS are installed despite turning off helm-controller #8853

Closed
brandond opened this issue Nov 14, 2023 · 1 comment
Closed
Assignees
Milestone

Comments

@brandond
Copy link
Member

Backport fix for Helm CRDS are installed despite turning off helm-controller

@aganesh-suse
Copy link

Environment Details

Infrastructure

  • Cloud
  • Hosted

Node(s) CPU architecture, OS, and Version:

$ cat /etc/os-release
PRETTY_NAME="Red Hat Enterprise Linux 9.3 (Plow)"

$ uname -m
x86_64

Cluster Configuration:

1 server/ 1 agent

Describe the bug:

Config.yaml:

$ sudo cat /etc/rancher/k3s/config.yaml
token: xxxx
protect-kernel-defaults: true
disable-cloud-controller: true
disable-helm-controller: true
disable-network-policy: true
disable:
  - traefik
  - servicelb
  - helm-controllercluster-init: true
write-kubeconfig-mode: "0644"
node-external-ip: 1.1.1.1
node-label:
- k3s-upgrade=server
selinux: true

Testing Steps to Reproduce:

  1. Copy config.yaml
$ sudo mkdir -p /etc/rancher/k3s && sudo cp config.yaml /etc/rancher/k3s
  1. Install k3s
$ curl -sfL https://get.k3s.io | sudo INSTALL_K3S_VERSION='v1.26.11+k3s2' sh -s - server
  1. Get api resources and grep for helm values. There should be none.
$ sudo /usr/local/bin/kubectl --kubeconfig /etc/rancher/k3s/k3s.yaml api-resources | grep helm

Replication Results:

$ k3s -v
k3s version v1.26.10+k3s1 (a6687b59)
go version go1.20.10
$ sudo /usr/local/bin/kubectl --kubeconfig /etc/rancher/k3s/k3s.yaml api-resources | grep helm
helmchartconfigs                               helm.cattle.io/v1                      true         HelmChartConfig
helmcharts                                     helm.cattle.io/v1                      true         HelmChart

Validation Results:

$ k3s -v
k3s version v1.26.11+k3s2 (66be20f1)
go version go1.20.11
$ sudo /usr/local/bin/kubectl --kubeconfig /etc/rancher/k3s/k3s.yaml api-resources | grep helm

@github-project-automation github-project-automation bot moved this from To Test to Done Issue in K3s Development Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants