Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing seems to require finalNewline regardless of finalNewline option #33

Open
justinaray opened this issue Nov 1, 2023 · 0 comments

Comments

@justinaray
Copy link

The parsing of the json file seems to fail if there's a trailing newline and doesn't seem to consult the finalNewline option. I recognize the finalNewline is likely an output option, but would be great if we could have an option to control if it's allowed in the source translation files.

it's pretty common on *nix systems, editor configs, and IDE formatters to insert a trailing newline.

I actually had to remove --check from my command to format so I could find the issue.

npx sync-i18n --files '**/src/i18n/*.json' --primary "en-us" --space 4 --finalNewline true --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant