Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GUI checkbox to demux .srt subtitles to either .srt or .sup #886

Open
vertigo220 opened this issue Jun 25, 2024 · 18 comments
Open

Add GUI checkbox to demux .srt subtitles to either .srt or .sup #886

vertigo220 opened this issue Jun 25, 2024 · 18 comments
Labels
enhancement New feature or request

Comments

@vertigo220
Copy link

I don't even know how this is possible, but whenever I use tsMuxer to demux mkv files containing .srt subs, it spits out subtitle files in the .sup format. Viewing the mkv file in MediaInfo shows they are in text format with a size in the tens of KB, yet the results from tsMuxer are files in the tens of MB. Loading the file into Subtitle Edit, it's able to directly read and show the text due to being in .srt format, but trying to load the output from tsMuxer results in needing to run OCR on it.

I'm baffled at how it's even getting graphical subtitle files from text ones, but more importantly it would be extremely helpful if it demuxed them as they are, i.e. pgs when they're pgs and srt when they're srt. This would save a lot of time as opposed to having to go through and load each one individually in Subtitle Edit.

@lgoncal
Copy link

lgoncal commented Jul 4, 2024

I find this feature quite useful.
Easy way to convert srt to pgs.
TS, after all, uses pgs, ie m2ts.
If you need srt subs from a mkv then use gMKVExtract

@vertigo220
Copy link
Author

I still think it would be nice to have it at least as an option in tsMuxer, but thank you for pointing me to that program. Seems to do what I need quite well.

@Nemesh64
Copy link

Nemesh64 commented Jul 6, 2024

I also prefer the subtitele in .srt format.
Because then I can use the {\an8} command when there is burned in text in the video.
It then moves the subtitle to center top in the screen.
This can not be done when de subtitle is in .sup format.

@lgoncal
Copy link

lgoncal commented Jul 6, 2024

This is about demuxing from a MKV file, not preferences or what you can do with srt.
Using the proper tool for the job goes a long way.
This is tsMuxer, it does TS and M2TS.
Use the tool I mentioned to get srt from a MKV, that is what it was built for, hence its name.
Or maybe tsMuxer should output MKV, MP4, DVD as well?

@vertigo220
Copy link
Author

@lgoncal I get your point, and I've been using gMKVExtract the past couple days and it's been doing the job, but according to your logic, tsMuxer should even accept MKVs or demux the video and audio files like it does. To just limit it to TS/M2TS functionality would make it much more limited than it already is, and would be unnecessary. The bottom line is, a file that contains .srt files, when demuxed, should result in .srt files, not .sup/.pgs/etc files. And as I said, I don't even know how it's getting those, as they don't exist in the MKV. While the program you suggested (and thanks for that) does work, I've been using tsMuxer for several years and it's done the job just fine, save for this one thing, and I'm not sure if I've ever used it with TS/M2TS files. And I like a lot of things about its UI better (though some things are better with gMKVExtract). And it's always nice to have more than one option to accomplish things. So I don't see the harm in making a program designed to demux files demux files into their constituent components, rather than into components they don't even contain. And as long as it's an option, there shouldn't be any issue.

I absolutely agree it should be an option, so those that use it like you do won't be affected by the change, but for those that use it just fine for MKV files, it would be nice to have it work as expected with subtitles. Either way, whatever the dev decides, since I have an alternative thanks to you I'll be fine, but I'm still curious how it even manages to get formats that aren't in the MKV file (at least not in any standard and obvious way).

@Nemesh64
Copy link

Nemesh64 commented Jul 7, 2024

I agree Vertigo,
If I demux a file with TsMuxer it should demus it to it's original form.
I can always use Suntitle Edit for creating a .sup file.
Maybe jcdr428 can add the option to choose to extract it to .srt or .sup.

In addition...
Not all Blu-Ray's and/or 4K's are released in my county.
So I subtitle a lot Blu-Ray's and 4K's from those country's with my native subtitle.
And believe me, in other country's much, much more Blu-Ray's and 4K's are released then in my country.
So TsMuxer is a software tool I simply can't miss it and helps me a lot.
To translate from my native language: "it's my right hand".
So I hoop jcdr428 will keep working/improving on TsMuxer.

@lgoncal
Copy link

lgoncal commented Jul 7, 2024

You demux a file with tsMuxer, meant to create ts streams, and you expect an output that is not related to transport streams.
Again, why not ask for MP4, and MKV output, they to have nothing to do with transport streams.
If you are using MKV and MP4 then use programs that are meant to use them.
If I demux with tsMuxer then I expect output that can be used in transport streams.
As for more options that just creates complexity for maintenance.
The ability to handle these inputs is so that tsMuxer can create transport streams with them, hence the sup files.
You guys want a jack of all trades software, which this is not, and those tend to become bloated and buggy with time.

@Nemesh64
Copy link

Nemesh64 commented Jul 7, 2024

If the original file in the mkv is a .srt, then the demux output should be .srt.
And if you want a .sup file, you can use Subtitle Edit.
I am not asking for more options, I just want the .srt file to be demuxed and not during that proces to be converted to .sup.

@lgoncal
Copy link

lgoncal commented Jul 7, 2024

Someone is inputting mkv to create an avchd, ts, m2ts or BD structure, which might be considered one of the main functions of this software.
So, are we to end up with srt in a blu ray structure, not good, how many demux routines is tsMuxer supposed to support?
Or should the devs code different demux routines?
Again, use the right software for the job, and if you want a jack of all trades type of software go get one.
It has output pgs for a long time, maybe since the beginning. There might be a reason.
And if you want srt why don't you use gmkvextract instead of posting here that you want this software changed?
I'm done with this.
Version 1.2 didn't even recognize srt, for your info

@Nemesh64
Copy link

Nemesh64 commented Jul 8, 2024

Demuxing: "Demultiplexing (a.k.a. demuxing) is the process of extracting each individual signal from within a single stream, where these signals have previously been combined via multiplexing."
According to that definition TsMuxer should not be able to export it to a .sup file because that is converting a .srt file and you can do that with Subtitle Edit.
You can find Subtitle Edit here: http://www.nikse.dk/
And I never mux a .srt straight into a BD structure (and I didn't write that).
When I have a .srt I make corrections (using Subtitle Edit) in the text, place text center above (if text is burned in into the video), use the italic command, check for double lines, etc. etc.
Often a mkv has a other fps then the Blu-Ray has.
Example the .srt from the .mkv runs at 23.976 fps and the Blu-Ray I am using runs at 24 fps.
I use Subtitle Edit to adjust the fps with the sync function: Synchronization -> Change Frame Rate
And I can't do all that with a .sup file.
When done, I export the .srt with Subtitle Edit to .sup (Blu-Ray 1920x1080p) and set the appropriate color for the subtitle.
231 for Blu-Rays and 181 for UHD's.
And after that, I use TsMuxer to combine that .sup file with the Blu-Ray video- and audio streams.
So to stay in your words (Again, use the right software for the job,) I use the right software for the job!
And just because version 1.2 didn't recognize .srt should be a reason not to export it as .srt?
So the request from Vertigo was a good one.
Maybe JCDR can create a option in TsMuxer to export it as a .srt or as a .sup file and keep everybody happy.
And I support that request.

@jcdr428 jcdr428 changed the title Demuxing .srt subtitles results in .sup subtitles Add GUI checkbox to demux .srt subtitles to either .srt or .sup Jul 8, 2024
@jcdr428 jcdr428 added the enhancement New feature or request label Jul 8, 2024
@jcdr428
Copy link
Collaborator

jcdr428 commented Jul 8, 2024

"Enhancement" request added...

@Nemesh64
Copy link

Nemesh64 commented Jul 9, 2024

Thanks Jcdr.
Will also show a screenshot with the settings I use to export a .srt to .sup:

Example

This setting gives really good subtitles for Blu-Ray.
The color is set to: E7E7E7
If I export for a 4K/UHD the setting is: B5B5B5

BluRay Color Setting

UHD Color Sedtting

With regards,

Nemesh

@lgoncal
Copy link

lgoncal commented Jul 9, 2024

Thanks for sharing, but...
.ts is not compatible with srt, but is meant to use pgs.
The pgs files that tsMuxer creates vwork fine, so they should be created as is.
Any adjustments can be done with bdsup2sub, if needed, by the user.
No need for suptitle edit o be involved with the pgs streams.
All pre and post processing should be done by the user independantly

@Nemesh64
Copy link

JCDR annded the request as Enhancement.
No need to discuss this any futher.

@lgoncal
Copy link

lgoncal commented Jul 10, 2024

I realize he amended the request.
No need to discuss, yet you are still indicating your preferred settings that should be used
Just like your definition of demultiplexing, not complely accurate, to be polite

@vertigo220
Copy link
Author

@lgoncal I'm not trying to get an argument going or be difficult here, but you're stuck on the fact that .srt is not compatible with ts/m2ts files and so tsMuxer shouldn't "create" them. That would be fine, if it were creating them, but it's not. If I mux a video stream, audio stream, and .srt file into an mkv, then I demux it, I should get out what I put in, exactly, meaning it should simply be demuxing, i.e. not creating, the .srt file. The point is, it should not be creating anything. Yet it is; it's creating a .sup file. So while yes, I understand that's the subtitle format compatible with the file formats this program is designed to work with, it's not a true demux.

And more to the point, as I said before, I'd like to know, for my own knowledge, how this is even possible. How is it creating a bitmap image file from a text-based file? Is it running the text through some processing to convert it and actually creating the file? Because based on the setting terminology of "demux," I assumed it was simply, well, demuxing, not creating. So is the terminology incorrect, or is the data for the .sup file somehow embedded in there somewhere? I'm genuinely asking, because it doesn't make sense.

@Nemesh64
Copy link

I realize he amended the request. No need to discuss, yet you are still indicating your preferred settings that should be used Just like your definition of demultiplexing, not complely accurate, to be polite

To be honest, I really don't care what demuxing according to your definition is.
JCDR is the programmer of TsMuxer and he amended it as a enhancement.
Case closed.

@lgoncal
Copy link

lgoncal commented Jul 11, 2024

I realize he amended the request. No need to discuss, yet you are still indicating your preferred settings that should be used Just like your definition of demultiplexing, not complely accurate, to be polite

To be honest, I really don't care what demuxing according to your definition is. JCDR is the programmer of TsMuxer and he amended it as a enhancement. Case closed.

Sorry, i shouldn't have accurate, I should have said honest.
Brought that up and you get all sensitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants