Explicitly signal stream initiation and termination #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickCao
force-pushed
the
stream-termination
branch
from
b6671cb to
97aeb76
Compare
mangelajo
reviewed
Aug 6, 2024
|
|
||
| async with remote: | ||
| async for v in forward_server_stream(request_iterator, remote): | ||
| yield v | ||
|
|
||
| del self.resources[resource_uuid] | ||
| # del self.resources[resource_uuid] | ||
| # small resources might be fully buffered in memory |
There was a problem hiding this comment.
Sequence of event:
- client opens a stream for sharing resource
- exporter accepts the stream and registers the other end of the stream as a resource
- exporter starts task to forward data from the client side of the stream to the exporter side of the stream
3.1 (actually happened) stream is copied into internal buffer before being consumed, forward tasks exits, resource unregistered - (originally intended) driver get the stream from the dict and begins consuming the stream
4.1 (actually happened) driver fails to find resource - (originally intended) stream is fully consumed by the driver, forward tasks exits, resource unregistered
There was a problem hiding this comment.
TLDR: resource shouldn't be unregistered when forwarding task exits, but only when it's fully consumed (or client decides to cancel)
There was a problem hiding this comment.
Thanks for the explanation I see now :-)
mangelajo
requested changes
Aug 6, 2024
NickCao
force-pushed
the
stream-termination
branch
from
57a9b39 to
2a3f62e
Compare
mangelajo
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.